Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13894 closed patch (fixed)

Encrypted connections configuration in Gadu-Gadu

Reported by: tomkiewicz Owned by:
Milestone: 2.8.0 Component: Gadu-Gadu
Version: 2.7.11 Keywords: ssl
Cc:

Description

It is not possible to turn on or off encrypted connections (introduced in #13613). It can make problems, if gnutls is installed in the system, but broken.

It's better to give the users ability to require or not encrypted connections. I made it - see patch. Also, I have fixed two small issues with TLS support, which caused warnings.

Attachments (3)

pidgin-gg-tls-configuration.patch (4.0 KB) - added by tomkiewicz 8 years ago.
TLS configuration in GaduGadu?
pidgin-gg-tls-configuration-2.patch (4.0 KB) - added by tomkiewicz 8 years ago.
Fixed ifdefs
pidgin-gg-tls-configuration-3.patch (3.7 KB) - added by tomkiewicz 8 years ago.
TLS if possible, instead of forced.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by tomkiewicz

TLS configuration in GaduGadu?

Changed 8 years ago by tomkiewicz

Fixed ifdefs

Changed 8 years ago by tomkiewicz

TLS if possible, instead of forced.

comment:1 Changed 8 years ago by elb

I'm not sure I understand the -3 patch ... it seems to me it forces TLS if the encryption type is set to opportunistic_tls, is that not what it's doing?

comment:2 Changed 8 years ago by tomkiewicz

TLS flag in gg_login_params set to 1 means "enabled", not "required". If encryption is not compiled in, it will silently go unencrypted.

In next version of libgadu there will be three values supported:

  • 0 = GG_SSL_DISABLED (never use ssl)
  • 1 = GG_SSL_ENABLED (use ssl when possible)
  • 2 = GG_SSL_REQUIRED (the new one - force ssl)

it's commited here: http://toxygen.net/websvn/listing.php?repname=libgadu&path=%2F&rev=1093

But we shouldn't use this patch, as it changes a bit API of libgadu (and external libgadu would work totally different).

comment:3 Changed 8 years ago by tomkiewicz@…

  • Milestone set to 2.8.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 2e94ea15a78df7b7f3afb0c117bd8e1b86e849b1):
gg: Allow the user to choose whether to use SSL/TLS support. Fixes #13894.

comment:4 Changed 8 years ago by rekkanoryo@…

(In fe1e545296641502337c940e326cd8a5ae62a57d):
Mention that patch in the ChangeLog. Refs #13894.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!