Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#14245 closed defect (fixed)

[PATCH] Make the username_entry hint fully visible

Reported by: sbrabec Owned by:
Milestone: 3.0.0 Component: pidgin (gtk)
Version: 2.7.11 Keywords:
Cc:

Description

The Add account GUI does not take in account the size of the username hint (login_label), which may render this label unreadable.

Technical details: pidgin abuses GtkEntry? to display informative text which disappears on click. GtkEntry? is not aware of such abuse and ignores size of text, as it implements its own scrolling mechanism. It makes the text concatenated.

GtkEntry? does not provide direct access to the entry text widget (and probably even does not have such), just a entry text GdkWindow?. This GdkWindow? is not yet initialized in time of the widget creation, so I have to repeat computations from gtk+/gtk/gtkentry.c _gtk_entry_effective_inner_border().

That is why the patch is a bit ugly, as well as adding an auto-disappearing string into GtkEntry?. Another solution would less hacky way to display hint.

The patch also modifies the hint color from a hardcoded color to a theme-wise color.

The patch is still a bit incomplete. To be perfect, this code should be moved to the "notify" handler of the default style, so it will reformat GUI after theme change.

Attachments (3)

pidgin-account-dialog-size.patch (1.5 KB) - added by sbrabec 8 years ago.
pidgin-account-dialog-size.patch
pidgin-msn-account.png (28.4 KB) - added by sbrabec 8 years ago.
screenshot that demonstrates the fix (LANG=es_ES.UTF-8, made before color adjustment)
pidgin-account-dialog-size.2.patch (4.0 KB) - added by sbrabec 8 years ago.
New version of the patch that behaves correctly on style change and removes yet another hardcoded color.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by sbrabec

pidgin-account-dialog-size.patch

Changed 8 years ago by sbrabec

screenshot that demonstrates the fix (LANG=es_ES.UTF-8, made before color adjustment)

comment:1 Changed 8 years ago by Robby

  • Milestone set to Patches Needing Review

Changed 8 years ago by sbrabec

New version of the patch that behaves correctly on style change and removes yet another hardcoded color.

comment:2 Changed 8 years ago by deryni

The original plan had been to look into using a more appropriate widget (subclassing our own if need be for this) with the current method working well enough for the time being. I like the idea behind this patch but can't evaluate its implementation at the moment.

comment:3 Changed 6 years ago by Stanislav Brabec <sbrabec@…>

  • Milestone changed from Patches Needing Review to 3.0.0
  • Resolution set to fixed
  • Status changed from new to closed

(In [408990fbee7b]):
Make the username_entry hint fully visible.

Fixes #14245.

comment:4 Changed 6 years ago by Elliott Sales de Andrade <qulogic@…>

(In [9abf92629647]):
Implement a GTK3 version of the placeholder text.

It might be a bit buggy, but I don't care too much, since 3.2 introduces a builtin method for it.

Refs #14245.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!