Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#14608 closed patch (fixed)

Clean up Sametime

Reported by: clokep Owned by: siege
Milestone: v2.10.1 Component: Sametime
Version: 2.9.0 Keywords:
Cc:

Description

While re-adding Sametime support to Instantbird I made Sametime compile with MSVC, Florian informed me that his changes of this type were accepted upstream.

This patch also adds in the Username Split that was removed at some point (I believe this was removed when the sametime plug-in was still part of a separate project on sourceforge).

I'm not sure how applicable it is, but our bug on the issue is: https://bugzilla.instantbird.org/show_bug.cgi?id=102

We have had reports that these changes work fine, although I'm not sure how backward compatible they are. I'm willing to put some effort into getting this upstream into libpurple, so let me know if things need to be changed.

Attachments (1)

sametime.diff (8.5 KB) - added by clokep 8 years ago.
MSVC compatibility & usernamesplit

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by clokep

MSVC compatibility & usernamesplit

comment:1 Changed 8 years ago by Robby

  • Milestone changed from 2.10.1 to Patches Needing Review

comment:2 Changed 7 years ago by rekkanoryo

I apologize for this patch sitting around for so long. Currently we have no one who is active in our development who knows anything about Sametime. That said, it compiles, so I'm shipping it.

comment:3 Changed 7 years ago by Patrick Cloke

  • Milestone changed from Patches Needing Review to 2.10.1
  • Resolution set to fixed
  • Status changed from new to closed

(In 0b7caf6b17815fe333d151369f26330d4c662bda):
Fix up the Sametime prpl to play nice with Visual C++. This patch also puts back a username split that was removed just about forever ago. Fixes #14608.

comment:4 Changed 7 years ago by Robby

  • Milestone changed from 2.10.1 to v2.10.1
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!