newline is missing after the PART command sended to the IRC server

[cLx]

I closed a IRC channel's conversation. Some times after that, some users messaged me that all my list of friends (on that IRC network) was sent to publicly the channel. Ohhhh, GREAT! Please, before to 'commit' something (and maybe before releasing it), testing your code would be so appreciated !

The newline after the PART command seem to be missing, so the server doesn't execute it. So, when Pidgin is polling (with ISON) for people some time after that, it get concatenated with the previous PART, and send it as comments for leaving the channel...

I retried, it seem to be reproducible (with another command than ISON this time).

Pidgin 2.10.0 (libpurple 2.10.0)

• cLx (~kou@myhostaddress) has left #thechannel (ISON nick1 nick2 nick3 nick4 nick5 nick6 nick7 nick8 nick9 nick10 nick11 nick12@… nick13 nick14 nick15 nick16 nick17 nick18 nick19 nick20 nick21 nick22 cLx nick24 nick25 nick26 nick27 nick28 nick29 nick30 nick31 nick32 nick33 nick34 nick35 nick36 nick37 nick38 nick39 nick40 nick41 nick42 nick43 nick44 nick45 nick46 nick47 nick48 nick49 nick50 nick51 nick52 )

• cLx (~kou@myhostaddress) has left #thechannel (JOIN #thechannel)

[elb]

I will ignore your snarky and ignorant comments on testing, as I'm sure you were simply confused, and help you anyway.

We are aware of this bug, and it appears to happen only to users of the IRC More plugin. I have not been able to reproduce it with a Pidgin install which does not have third-party plugins installed. There were some changes to the irc_send_raw() mechanism to fix bugs in the previous implementation which may have broken third-party plugins which depended on the old behavior. I have it on my TODO to see if I can mitigate these problems.

If you are NOT using the IRC More plugin, I would like to know about it.

Ethan

[cLx]

Thanks for your reply,

* off-topic mode on * Sorry for the comments about testing, last time it was a nasty issue about the nicklist (working, then broken with the upgrade). And before that, the option permitting to accept an expired SSL certificate -- sometimes, the admins are just lazy to renew they certificate but.. it's nice to use encryption anyway. Was possible, then impossible, then back ok. The sensation of fear on every update is not enjoyable. I guess Pidgin gets overall betters, but, as a coder (not in the pidgin project), I've the sensation more testing should be done anyway. * off-topic mode off *

Btw, you were right about the 'IRC More' plugin, it was activated. For long time ago I guess. It's now desactivated. Is there more plugins I should be sure they're not in use ?

It could be interesting, in the way of avoiding this sort of things to happen (in that case, privates informations released onto a public channel) to maintain a list of know now incompatibles plugins (based on the plugins versions) and to display a warning about it when pidgin is executed.

[datallah]

Ticket #15234 has been marked as a duplicate of this ticket.

[datallah]

Ticket #15283 has been marked as a duplicate of this ticket.