Opened 7 years ago

Last modified 3 years ago

#14714 new patch

"Attention" messages in an established XMPP conversation are sent to a bogus Jabber ID

Reported by: itsnotabigtruck Owned by: deryni
Milestone: Patches Needing Review Component: XMPP
Version: 2.10.0 Keywords: attention buzz jabber xmpp jid resource
Cc: philw, OmegaPhil

Description

When the "Send Attention" button is used to 'buzz' a contact in an already-established XMPP conversation, the message is sent to an incorrectly constructed full Jabber ID (JID). As a result, the recipient is not alerted. The 'buzz' is successfully received if it is sent from a newly opened conversation window.

Valid XEP-0224 attention message:

<message to='user@doma.in/resource' type='headline'>
	<attention xmlns='urn:xmpp:attention:0'/>
</message>

Invalid XEP-0224 attention message:

<message to='user@doma.in/resource/resource' type='headline'>
	<attention xmlns='urn:xmpp:attention:0'/>
</message>

As a result, the "Send Attention" feature is largely inoperative when used with XMPP contacts.

Client: Pidgin 2.10.0
Server: Prosody (trunk)

Attachments (2)

pidgin-2.10.11-#14714-fix.patch (402 bytes) - added by philw 3 years ago.
Patch for 2.10.11, tested
pidgin-main-#14714-fix.patch (422 bytes) - added by philw 3 years ago.
Patch for main branch of Mercurial repository, untested

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by neufeind

Haven't yet had a chance to try this out myself. But is this still an issue, for so long?

Changed 3 years ago by philw

Patch for 2.10.11, tested

Changed 3 years ago by philw

Patch for main branch of Mercurial repository, untested

comment:2 Changed 3 years ago by philw

Yes it's still an issue in 2.10.11, I have attached a patch which I tested with 2.10.11.

comment:3 Changed 3 years ago by Robby

  • Milestone set to Patches Needing Review
  • Type changed from defect to patch
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!