Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14983 closed defect (fixed)

Crash in error on ICQ

Reported by: xnyhps Owned by: MarkDoliner
Milestone: 2.10.2 Component: ICQ
Version: 2.10.1 Keywords: icq crash error snachandler
Cc:

Description

#a15881 has multiple people reporting a crash in:

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000000
Crashed Thread:  0

Thread 0 Crashed:
0   libpurple                     	0x007879f0 error + 212
1   libpurple                     	0x00789c80 snachandler + 76
2   libpurple                     	0x0079bc68 parse_snac + 336
3   libpurple                     	0x0079bf90 parse_flap + 188
4   libpurple                     	0x0079c3a4 flap_connection_recv + 980
5   libpurple                     	0x0079c428 flap_connection_recv_cb + 44

The last line in the debug log being:

(Libpurple: oscar) Requesting ICQ alias for xxx

I believe this is a problem in family_icq.c:error(): it looks up the original_info_ptr in a linked list, and then tries to get the ->data from it (line 94), before checking wether it is NULL (line 96), i.e., wether the lookup succeeded.

Change History (3)

comment:1 Changed 7 years ago by thijsalkemade@…

(In 2e027ee15ef29e082eceea9ec99347cf8751ac4a):
Fix a possible crash when receiving an unexpected message from the server on ICQ.

Refs #14983

comment:2 Changed 7 years ago by markdoliner@…

  • Milestone set to 2.10.2
  • Resolution set to fixed
  • Status changed from new to closed

(In 09d2e29b6ff4dcc675099f74645ca2eb119ad6b5):
Fixes #14983

* Plucked 2e027ee15ef29e082eceea9ec99347cf8751ac4a (thijsalkemade@…): Fix a possible crash when receiving an unexpected message from the server on ICQ.

Refs #14983

comment:3 Changed 7 years ago by MarkDoliner

Thanks, Thijs! Your change looks great to me. I plucked it into Pidgin's 2.x.y branch, from which we'll release version 2.10.2 hopefully within the next week.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!