Changes between Initial Version and Version 2 of Ticket #15053


Ignore:
Timestamp:
07/22/12 03:09:34 (7 years ago)
Author:
QuLogic
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15053

    • Property Milestone changed from to Patches Needing Review
  • Ticket #15053 – Description

    initial v2  
    1 Re-fix a double-free in the Yahoo profile/picture code.[[BR]]
    2 [[BR]]
    3 User data passed to '''purple_util_fetch_url'''/'''purple_util_fetch_url_request''' is[[BR]]
    4 already freed by the '''yahoo_got_info'''/'''yahoo_fetch_picture_cb''' callbacks on the[[BR]]
    5 error paths.[[BR]]
    6 This happens since '''purple_util_fetch_url_error''' calls were introduced to[[BR]]
    7 '''purple_util_fetch_url_request''' by revisions:[[BR]]
    8 [[BR]]
     1Re-fix a double-free in the Yahoo profile/picture code.
     2
     3User data passed to '''purple_util_fetch_url'''/'''purple_util_fetch_url_request''' is
     4already freed by the '''yahoo_got_info'''/'''yahoo_fetch_picture_cb''' callbacks on the
     5error paths. This happens since '''purple_util_fetch_url_error''' calls were introduced to '''purple_util_fetch_url_request''' by revisions:
     6
    9786dac605 by 'markdoliner' 03/17/2009[[BR]]
    108a1ad9ab6 by 'markdoliner' 12/06/2008[[BR]]
    11 [[BR]]
    12 [[BR]]
    13 History of this issue:[[BR]]
    14 [[BR]]
    15 1. Try to fix the same double-free I'm fixing now with a patch[[BR]]
     9
     10History of this issue:
     11
     121. Try to fix the same double-free I'm fixing now with a patch
    1613from downstream Debian:[[BR]]
    17 Revision: 7a490c356e10f7fff3432f875897aa0ca0ad1ff0[[BR]]
     14Revision: viewmtn:7a490c356e10f7fff3432f875897aa0ca0ad1ff0 [[BR]]
    1815Date:     05/22/2008 09:01:58 PM[[BR]]
    1916[[BR]]
    20 2. It seems that the previous patch introduced 2 memory leaks, which[[BR]]
     172. It seems that the previous patch introduced 2 memory leaks, which
    2118are fixed with:[[BR]]
    22 Revision: 7a36a9ecbcc902ee89656d5267e613aa1dc0b889[[BR]]
     19Revision: viewmtn:7a36a9ecbcc902ee89656d5267e613aa1dc0b889 [[BR]]
    2320Date:     06/09/2008 12:54:56 AM[[BR]]
    2421and[[BR]]
    25 Revision: c7c882ce933f14ae4b89d4c9782a84accaec53b5[[BR]]
     22Revision: viewmtn:c7c882ce933f14ae4b89d4c9782a84accaec53b5 [[BR]]
    2623Date:     07/19/2008 12:10:23 AM[[BR]]
    2724[[BR]]
    28253. Modification in libpurple/util.c reintroduced the double-free:[[BR]]
    29 Revision: a1ad9ab6671970d851852ea29ac86fbd0b43a2f2[[BR]]
     26Revision: viewmtn:a1ad9ab6671970d851852ea29ac86fbd0b43a2f2 [[BR]]
    3027Date:     12/06/2008 03:08:20 AM[[BR]]
    3128and [[BR]]
    32 Revision: 86dac605e7e7ef1ac36e03862a15ef24ef31d9dc[[BR]]
    33 Date:     03/17/2009 12:56:57 AM[[BR]]
     29Revision: viewmtn:86dac605e7e7ef1ac36e03862a15ef24ef31d9dc [[BR]]
     30Date:     03/17/2009 12:56:57 AM
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!