Opened 6 years ago

Last modified 5 years ago

#15129 new task

WebKit regressions

Reported by: tomkiewicz Owned by:
Milestone: 3.0.0 Component: pidgin (gtk)
Version: Keywords: webkit
Cc: salinasv, nwalp, marsjaninzmarsa

Description

After finishing WebKit integration on trunk, there came up some regression problems:

  • default theme doesn't look like the legacy one (1)
  • plaintext logs doesn't display well (2)
  • incoming messages (at least on gadu-gadu protocol) are not linkified (3)
  • "Show Timestamps" tick doesn't work
  • inline images doesn't work (at least on gg)
  • nicknames in conferences are not colored (they should match room presence list colors)
  • context menu in conversation window: "Reload" position isn't necessary; "Open Link" for links should be removed (it allows to open sites inside conversation window)

Some fixes (at mine branch):

Change History (7)

comment:1 Changed 6 years ago by salinasv

  • Cc salinasv added

comment:2 Changed 5 years ago by nwalp

I've committed fixes for the conference nickname coloring. Supports theme specification as well.

comment:3 follow-up: Changed 5 years ago by tomkiewicz

For now, all pointed regressions are fixed, but we got another ones:

  • there is no possibility to send just a single image, without text (input won't pass it)
  • input area have constant size (doesn't extend while typing)
  • status description input area is always visible, doesn't hide after setting a new status
  • there is no possibility to select spell-checked language

Also, my wish-list:

  • Inspect Element button is available only for conversation area - not other webkit widgets
  • font size in input areas could be smaller and had smaller padding

comment:4 Changed 5 years ago by tomkiewicz

  • Milestone set to 3.0.0

comment:5 in reply to: ↑ 3 ; follow-up: Changed 5 years ago by QuLogic

  • Type changed from defect to task

Replying to tomkiewicz:

For now, all pointed regressions are fixed, but we got another ones:

  • there is no possibility to send just a single image, without text (input won't pass it)

If we can figure out this part:

	if (GTK_WEBVIEW(gtkconv->entry)->im_images != NULL)
		flags |= PURPLE_MESSAGE_IMAGES;

then we should be able to fix the conditional.

  • input area have constant size (doesn't extend while typing)

I have tried several things, but still have no idea how to get the height of the content. It's also a bit troublesome for the status entry.

  • status description input area is always visible, doesn't hide after setting a new status
  • there is no possibility to select spell-checked language

Need to update the plugin for that though, right?

Also, my wish-list:

  • Inspect Element button is available only for conversation area - not other webkit widgets

It'd be difficult for the plugin to know where all the WebKit widgets are.

  • font size in input areas could be smaller and had smaller padding

It should use the default font, but WebKit has it's own ideas about that.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 5 years ago by tomkiewicz

Replying to QuLogic:

  • input area have constant size (doesn't extend while typing)

I have tried several things, but still have no idea how to get the height of the content. It's also a bit troublesome for the status entry.

Maybe try to use javascript here?

  • status description input area is always visible, doesn't hide after setting a new status
  • there is no possibility to select spell-checked language

Need to update the plugin for that though, right?

I'm not certain, if I understood this simple sentence, but yes - I think there is a need for update.

Also, my wish-list:

  • Inspect Element button is available only for conversation area - not other webkit widgets

It'd be difficult for the plugin to know where all the WebKit widgets are.

Maybe providing simple function, that sets it up in a single line for specified widget would be possible? Another idea - Pidgin UI could simply provide a list for all webkit widgets.

At least, it could be possible to /easy/ hardcode specified widget to be inspectable just for certain debug build.

comment:7 in reply to: ↑ 6 Changed 5 years ago by QuLogic

Replying to tomkiewicz:

Replying to QuLogic:

  • input area have constant size (doesn't extend while typing)

I have tried several things, but still have no idea how to get the height of the content. It's also a bit troublesome for the status entry.

Maybe try to use javascript here?

I didn't use JS, but as far as I can tell, everything that's available in JS that could tell me a height is also available in the GObject bindings. Feel free to give it a try though.

  • status description input area is always visible, doesn't hide after setting a new status
  • there is no possibility to select spell-checked language

Need to update the plugin for that though, right?

I'm not certain, if I understood this simple sentence, but yes - I think there is a need for update.

Sorry, I initially thought that plugin didn't come with Pidgin.

Also, my wish-list:

  • Inspect Element button is available only for conversation area - not other webkit widgets

It'd be difficult for the plugin to know where all the WebKit widgets are.

Maybe providing simple function, that sets it up in a single line for specified widget would be possible? Another idea - Pidgin UI could simply provide a list for all webkit widgets.

At least, it could be possible to /easy/ hardcode specified widget to be inspectable just for certain debug build.

Things like the webview in the debug window are not actually visible outside of their source files.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!