Opened 5 years ago

Closed 5 years ago

#15139 closed patch (fixed)

NULL pointer deref (crash) when ignoring an invalid chat buddy

Reported by: EionRobb Owned by:
Milestone: 2.10.5 Component: pidgin (gtk)
Version: 2.10.4 Keywords:
Cc:

Description

When ignoring a ChatBuddy? that is not present in the Chat room, Pidgin will crash. An example is when receiving a system information message from Freenode in IRC and ignoring the buddy.

Error occured on Thursday, May 31, 2012 at 09:32:47.

Windows Version 6.1 Build 7601 Service Pack 1

C:\Program Files\Pidgin\pidgin.exe caused an Access Violation at location 64a68791 in module C:\Program Files\Pidgin\pidgin.dll Reading from location 00000018.

Registers:
eax=00000000 ebx=0a41f640 ecx=00000000 edx=0022e148 esi=0533faa0 edi=0022e148
eip=64a68791 esp=0022e108 ebp=0022e120 iopl=0         nv up ei pl nz ac pe nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00210212

Call stack:
         C:\Program Files\Pidgin\pidgin.dll [2.10.4.0]
         Using Debug Symbols from: C:\Program Files\Pidgin\pidgin-2.10.4-dbgsym\pidgin.dll.dbgsym
64A68791 C:\Program Files\Pidgin\pidgin.dll  get_iter_from_chatbuddy  C:/cygwin/home/Eion/pidgin-2.10.4/pidgin/gtkconv.c:6135
64A68B2E C:\Program Files\Pidgin\pidgin.dll  pidgin_conv_chat_update_user  C:/cygwin/home/Eion/pidgin-2.10.4/pidgin/gtkconv.c:6318
         C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll [2.20.5.0]
63A44074 C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_closure_invoke
63A576D9 C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_signal_handlers_destroy
63A588F3 C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_signal_emit_valist
63A58E26 C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_signal_emit
         C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll [2.16.6.0]
01A3A3AF C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_widget_activate
01939B31 C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_menu_shell_activate_item
0193B6F9 C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_menu_shell_append
0192A262 C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_marshal_BOOLEAN__VOID
         C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll [2.20.5.0]
63A44074 C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_closure_invoke
63A573EC C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_signal_handlers_destroy
63A5878B C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_signal_emit_valist
63A58E26 C:\Program Files\Pidgin\Gtk\bin\libgobject-2.0-0.dll  g_signal_emit
         C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll [2.16.6.0]
01A34553 C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_widget_class_list_style_properties
01922C9A C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_propagate_event
01923C49 C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_main_do_event
         C:\Program Files\Pidgin\Gtk\bin\libgdk-win32-2.0-0.dll [2.16.6.0]
6C36CA7F C:\Program Files\Pidgin\Gtk\bin\libgdk-win32-2.0-0.dll  gdk_event_get_graphics_expose
         C:\Program Files\Pidgin\Gtk\bin\libglib-2.0-0.dll [2.20.5.0]
685EA27B C:\Program Files\Pidgin\Gtk\bin\libglib-2.0-0.dll  g_main_context_dispatch
685ED185 C:\Program Files\Pidgin\Gtk\bin\libglib-2.0-0.dll  g_main_context_prepare
685ED574 C:\Program Files\Pidgin\Gtk\bin\libglib-2.0-0.dll  g_main_loop_run
         C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll [2.16.6.0]
01924260 C:\Program Files\Pidgin\Gtk\bin\libgtk-win32-2.0-0.dll  gtk_main
         C:\Program Files\Pidgin\pidgin.dll [2.10.4.0]
         Using Debug Symbols from: C:\Program Files\Pidgin\pidgin-2.10.4-dbgsym\pidgin.dll.dbgsym
64A97F48 C:\Program Files\Pidgin\pidgin.dll  pidgin_main  C:/cygwin/home/Eion/pidgin-2.10.4/pidgin/gtkmain.c:944
         C:\Program Files\Pidgin\pidgin.exe [2.10.4.0]
         Using Debug Symbols from: C:\Program Files\Pidgin\pidgin-2.10.4-dbgsym\pidgin.exe.dbgsym
0040250B C:\Program Files\Pidgin\pidgin.exe  WinMain  C:/cygwin/home/Eion/pidgin-2.10.4/pidgin/win32/winpidgin.c:821
00402E58 C:\Program Files\Pidgin\pidgin.exe  WinMain  C:/cygwin/home/Eion/pidgin-2.10.4/pidgin/win32/winpidgin.c:726
0040124B C:\Program Files\Pidgin\pidgin.exe
004012B8 C:\Program Files\Pidgin\pidgin.exe
         C:\windows\system32\kernel32.dll [6.1.7601.17651]
7579ED6C C:\windows\system32\kernel32.dll  BaseThreadInitThunk
         C:\windows\SYSTEM32\ntdll.dll [6.1.7601.17725]
771A377B C:\windows\SYSTEM32\ntdll.dll  RtlInitializeExceptionChain
771A374E C:\windows\SYSTEM32\ntdll.dll  RtlInitializeExceptionChain

Attachments (1)

pidgin_fix_ignore_invalid_chatbuddy.diff (484 bytes) - added by EionRobb 5 years ago.
Patch to check for NULL ChatBuddy?'s

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by EionRobb

Patch to check for NULL ChatBuddy?'s

comment:1 Changed 5 years ago by darkrain42@…

  • Milestone set to 2.10.5
  • Resolution set to fixed
  • Status changed from new to closed

(In 5ca378b115ef36cfafb203fb88623734a7c6bb23):
Fix crash when ignoring message from a user not in the room. Fixes #15139

Occurs with IRC system messages on-login.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!