Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#15316 closed patch (fixed)

configure: do not use exit status 0 in case of error

Reported by: mfiedler Owned by: rekkanoryo
Milestone: 2.10.7 Component: unclassified
Version: Keywords:
Cc:

Description

In configure.ac, there are two checks for invalid options where exit is called without status 1. In these cases, the error that occured cannot be detected by checking the exit status of configure. This patch fixes the issue.

Attachments (1)

patch.diff (1001 bytes) - added by mfiedler 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by mfiedler

comment:1 Changed 3 years ago by rekkanoryo

I apologize for this patch sitting around so long with no action. I'm going to accept the patch. How should I credit you (name and preferably an e-mail address as well)?

comment:2 Changed 3 years ago by mfiedler

Please credit me as "Michael Fiedler <dev@…>" as in the attached patch.

comment:3 Changed 3 years ago by rekkanoryo

  • Milestone set to 2.10.7
  • Resolution set to fixed
  • Status changed from new to closed

I committed this in 33546:a91f4d6cb5dc but forgot to include the trac magic in the commit message.

comment:4 Changed 3 years ago by John Bailey <rekkanoryo@…>

(In [36d51c98dd7b]):
Ugh, forgot to changelog before pushing. Refs #15316.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!