Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#15373 closed patch (fixed)

upnp: upnp-mapping doesn't work on certain routers

Reported by: noonien Owned by: datallah
Milestone: 2.10.7 Component: libpurple
Version: 2.10.6 Keywords: upnp mapping file
Cc:

Description

Hi,

my router provides an empty "<URLBase/>" element in its upnp-descriptor. Because there actually is an urlbase-element, the baseUrl-Variable in the "purple_upnp_parse_description_response"-function stays empty.

With my patch, the routine checks if the baseUrl-Variable is NULL instead of relying on the presence of the xml-element (that may be empty).

If NULL, baseURL can be filled with the httpURL-variable.

I didn't find any matching tickets, maybe my router is uncommon :)

Attachments (1)

upnp.c.patch (452 bytes) - added by noonien 4 years ago.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by noonien

comment:1 Changed 4 years ago by datallah

  • Milestone set to 2.10.7
  • Owner set to datallah

comment:2 follow-up: Changed 4 years ago by salinasv

Can you give me the name you want me to credit for this patch?

comment:3 in reply to: ↑ 2 Changed 4 years ago by noonien

Replying to salinasv:

Can you give me the name you want me to credit for this patch?

My name is Ferdinand Stehle. Thank you for integrating the patch!

comment:4 Changed 4 years ago by Ferdinand Stehle <unknown>

  • Resolution set to fixed
  • Status changed from new to closed

(In [d79e18b1b043]):
Fix UPNP mapping on some weird routers. Fixes #15373.

comment:5 Changed 3 years ago by Jorge Villaseñor <salinasv@…>

  • Milestone changed from 2.10.7 to 3.0.0

(In [738d76cfdb6e]):
Check if the URLBase is empty in the xml-element instead of reying on it being present. This avioid upnp failing in certain routers.

Thanks Ferdinand Stehle for the patch Fixes #15373

comment:6 Changed 3 years ago by salinasv

  • Milestone changed from 3.0.0 to 2.10.7
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!