Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#15452 closed patch (fixed)

IRC SASL sends invalid commands for empty SASL data

Reported by: grawity Owned by: elb
Milestone: 2.10.8 Component: IRC
Version: 2.10.6 Keywords:
Cc:

Description

In some cases, sasl_client_step() returns a zero-length response (for example, when using the EXTERNAL mechanism).

When this happens, Pidgin sends AUTHENTICATE without any arguments and the server complains about "missing parameter". The correct way is to send a + as the data (i.e. AUTHENTICATE +).

Patch attached...hopefully.

Attachments (1)

pidgin-irc-sasl-empty-responses.patch (715 bytes) - added by grawity 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by grawity

comment:1 Changed 6 years ago by datallah

  • Type changed from defect to patch

comment:2 Changed 6 years ago by MarkDoliner

  • Milestone changed from 2.10.7 to 2.10.8

comment:3 Changed 5 years ago by Mantas MikulÄ—nas <grawity@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In [44348822264a]):
Correctly send empty IRC SASL responses. Fixes #15452

comment:4 Changed 5 years ago by Daniel Atallah <datallah@…>

(In [41f194fab201]):
Add Mantas Mikul?nas to COPYRIGHT. Refs #15452

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!