Opened 6 years ago

Last modified 6 years ago

#15481 new patch

patch pidgin's gtk deprecated symbols

Reported by: placidrage Owned by:
Milestone: Patches Needing Improvement Component: pidgin (gtk)
Version: 2.10.6 Keywords: pidgin gtk deprecated


Updated some of gtk3's deprecated symbols to decrease compile-time warnings.

Attachments (1)

pidgin-gtk-deprecated.patch (82.4 KB) - added by placidrage 6 years ago.
patch gtk3's deprecated symbols

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by placidrage

patch gtk3's deprecated symbols

comment:1 Changed 6 years ago by QuLogic

We can't actually do this unilaterally without dropping GTK2 support.

comment:2 Changed 6 years ago by QuLogic

  • Milestone changed from Patches welcome to Patches Needing Improvement

Don't set the milestone.

comment:3 Changed 6 years ago by placidrage

Why is GTK2 support so important? Who still uses it? This is from the mercurial main branches tip, so probably for the next release of pidgin, who do you think will need to use your next release with gtk2?

I'm just honestly curious.

Didn't know about the milestone thing, next time I won't set it. How about the version? what do I set it to when it's from hg's main branch's tip?

Just for information, those symbols were deprecated in gtk3.0, we are at least at 3.4, and there are plans about deprecating the gtk box widget all together, which is why there is a guide to port to gtk grid which will be the way to go when it comes to setting up the app's layout.

Would it make more sense if I start with that port now?

comment:4 Changed 6 years ago by rekkanoryo

It's still an open debate about whether we want to maintain GTK+ 2.x support when we release from the tip of the "main" hg repo. Currently we're releasing from the release-2.x.y branch because the tip of default is not ready and probably won't be soon. That said, as long as 2.x maintains GTK+ compatibility, I have no problem with killing GTK+ 2.x support for 3.0.0. By the time we get it, even annoying distributions like RHEL will have GTK+ 3.0.0. (Windows support is a completely different argument and part of the reason we haven't killed GTK+ 2.x support off entirely in 3.0.0 yet).

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!