IRC ACTIONs skip sending-im-msg signal.
|Reported by:||xnyhps||Owned by:||tomkiewicz|
|Version:||2.10.7||Keywords:||irc otr /me|
|Cc:||kroeckx, T(A)ILS, developers, frozencemetery, Robby|
Description (last modified by datallah)
For most protocols /me gets sent raw, but is displayed differently. For IRC, it is also sent differently. Because /me is interpreted as a command, it bypasses all normal message logic, including the "sending-im-msg" signal. This implies that, for instance, OTR does not get a chance to encrypt the message and it is sent in plain.
Because this is undesirable when using OTR, the "sending-im-msg" signal should fire. Attached patch implements this.
Note that it encrypts "\001ACTION " part too, to be compatible with other IRC clients with OTR support. I'm not sure this is desirable for all plugins that look for the "sending-im-msg" signal.
Change History (45)
Changed 4 years ago by xnyhps
comment:4 Changed 4 years ago by datallah
- Cc T(A)ILS developers added; T(A)ILS developers removed
- Description modified (diff)
- Milestone set to 2.10.8
comment:8 Changed 4 years ago by T(A)ILS developers
Changed 3 years ago by T(A)ILS developers
comment:15 Changed 3 years ago by T(A)ILS developers
comment:36 Changed 3 years ago by tomkiewicz
- Milestone changed from Patches Needing Review to 2.10.10
comment:37 Changed 3 years ago by Tomasz Wasilczyk <twasilczyk@…>
- Resolution set to fixed
- Status changed from new to closed