Opened 4 years ago

Closed 3 years ago

#15756 closed defect (fixed)

Pidgin doesn't read smiley theme files safely to handle multibyte characters

Reported by: Jeronimo17 Owned by: datallah
Milestone: 2.10.8 Component: pidgin (gtk)
Version: 2.10.7 Keywords: smiley,theme,unicode,crashes
Cc:

Description (last modified by Jeronimo17)

This is an example:

C:\program files\Pidgin\pixmaps\pidgin\emotes\default\theme

[Protocol]

Previous characters unicode also fail in the same way ...

../Protocol/E102.png  OK ../Protocol/E103.png  OK ../Protocol/E104.png  OK ../Protocol/E105.png  OK ../Protocol/E106.png  OK ../Protocol/E107.png (u+E107 Pidgin Crash) ../Protocol/E108.png  OK ../Protocol/E109.png  OK ../Protocol/E10A.png  OK ../Protocol/E10B.png  OK ../Protocol/E10C.png  OK ../Protocol/E10D.png  OK ../Protocol/E10E.png  OK ../Protocol/E10F.png  OK ../Protocol/E110.png (u+E110 Pidgin Crash) ../Protocol/E111.png (u+E111 Pidgin Crash) ../Protocol/E112.png  OK ../Protocol/E113.png (u+E113 Pidgin Crash) ../Protocol/E114.png  OK

Subsequent characters unicode also fail in the same way ...

Pidgin crash once I click on the smiley button

Attachments (2)

pidgin.RPT (42.1 KB) - added by technomalogical 3 years ago.
Pidgin crashing when clicking smilies palette button with unicode characters in "theme" file
theme (12.4 KB) - added by technomalogical 3 years ago.
theme file causing the crash

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by Jeronimo17

  • Description modified (diff)

comment:2 Changed 4 years ago by Jeronimo17

  • Description modified (diff)

comment:3 Changed 3 years ago by technomalogical

I have the same issue, although I haven't tested that only some of the Unicode characters are causing the crash. Tried in two versions, 2.10.4 and 2.10.7 and both crashed when hitting the smiley button on a message window. Both can use other themes.

Changed 3 years ago by technomalogical

Pidgin crashing when clicking smilies palette button with unicode characters in "theme" file

Changed 3 years ago by technomalogical

theme file causing the crash

comment:4 Changed 3 years ago by technomalogical

Looking at the RPT file, it looks like the problem appears to be with trying to set the value of the tooltip boxes with the unicode character. Not being familiar enough with Pidgin or GTK, I can't be sure if Pidgin is passing in an invalid value or if GTK is processing the correct value incorrectly. It appears that the "theme" file I posted is encoded UTF-8. Maybe it's possible that Pidgin is reading the file in with a different encoding.

comment:5 Changed 3 years ago by datallah

  • Component changed from winpidgin (gtk) to pidgin (gtk)
  • Summary changed from Pigdin (windows build) crashes when smiley theme file contains some unicode characters to Pidgin doesn't read smiley theme files safely to handle multibyte characters

This actually isn't a Windows specific problem. It's a bug in the parsing of certain multibyte characters that results in invalid utf-8 text being specified to the gtk+ backend.

comment:6 Changed 3 years ago by Daniel Atallah <datallah@…>

  • Milestone set to 2.10.8
  • Resolution set to fixed
  • Status changed from new to closed

(In [46ba9c764edc]):
Fix handling of multibyte utf-8 characters in smiley theme files. Fixes #15756.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!