Opened 5 years ago

Closed 4 years ago

#15906 closed task (fixed)

Remove Yahoo! Japan

Reported by: MarkDoliner Owned by: sulabh.dev
Milestone: 3.0.0 Component: Yahoo!/Yahoo! JAPAN
Version: Keywords:
Cc:

Description

Yahoo! Messenger Japan will be shut down on March 26, according to http://messenger.yahoo.co.jp/close/

We should remove our support for it in 3.0.0. We should remove libpurple/protocols/yahoo/libyahoojp.c We may also want to simplify the Yahoo! PRPL build process so that it doesn't build an intermediate library first.

We probably don't need to remove Yahoo! Japan accounts from accounts.xml. They won't be useful and will show up with protocol "Unknown," but I think that's fine. And it's kind of a good idea not to delete people's data unexpectedly.

Attachments (1)

yahoo-japan-remove.diff (24.6 KB) - added by mmcco 4 years ago.
Diff for the removal of Yahoo! Japan

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by MarkDoliner

Also:

  • Remove wiki info about Yahoo! Japan.
  • Close tickets about Yahoo! Japan.

comment:2 Changed 4 years ago by mmcco

Is this confirmed to have actually happened? I'm working on removing it from the tree now.

Changed 4 years ago by mmcco

Diff for the removal of Yahoo! Japan

comment:3 Changed 4 years ago by mmcco

Note three things in the above diff:

  • I used tabs rather than spaces (I'll fix this soon)
  • there was an apparent bug in libpurple/protocols/yahoo/yahoochat.c that was fixed by code removal
  • it's preliminary - I likely missed something or got something wrong
Version 1, edited 4 years ago by mmcco (previous) (next) (diff)

comment:4 Changed 4 years ago by mmcco

I missed quite a bit on the first sweep. Here's a new patch:

https://gist.github.com/mmcco/ff5b7408c903755a3b97

comment:5 Changed 4 years ago by mmcco

As Mark mentioned in the original ticket, the above patch doesn't remove Yahoo! Japan accounts from accounts.xml. Accounts and their passwords are retained and listed as unknown.

comment:6 Changed 4 years ago by mmcco

Also, for what it's worth, the servers seem to have actually been nixed. Attempted connections fail immediately with an "empty response" error. Additionally, many of the secondary domains (the YAHOOJP_* defines in libpurple/protocols/yahoo/ymsg.h) don't even resolve anymore.

comment:7 Changed 4 years ago by mmcco

This as been reviewed and merged into the main branch:

https://hg.pidgin.im/pidgin/main/rev/3032113d656e

This ticket should probably be closed.

If anyone finds any vestiges of Yahoo Japan, let me know.

comment:8 Changed 4 years ago by Robby

  • Resolution set to fixed
  • Status changed from new to closed

That makes this issue "fixed", no? :-)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!