Opened 5 years ago

#16263 new patch

Change history behavior of up/down keys

Reported by: UnixRonin Owned by:
Milestone: Component: pidgin (gtk)
Version: 2.10.9 Keywords: Ctrl Up Down history


This is a partial, first-draft response to enhancement request #15488, although I did not actually know about #15488 when I started working on it. I was simply irritated at the default behavior, and at the fact that I've been using pidgin for more years than I can remember and did not discover until today that it has a history-recall feature because it never occurred to me to try Ctrl-Up/Ctrl?-Dn instead of a simple Up/Dn?.

Simply: The behavior of Up/Dn? vs. Ctrl-Up/Ctrl?-Dn in the interface is inconsistent. Up/Dn? moves through different lines of a multiline entry, while those lines are created by Ctrl+Enter or Shift+Enter; meanwhile, Ctrl-Up and Ctrl-Dn scroll through conversation history, behavior which in almost any other chat client that allows recalling previously typed lines is done by Up/Dn?.

(Additionally, I admit, typed history is a feature I use a LOT, while I rarely if ever use the cursor keys to edit multiline entries.)

This is a partial, simplistic first-cut at the problem which, depending upon the value of the constant HISTORY_USES_CTRL in gtkconv.c, changes the history to use unadorned Up/Dn?. I have not yet found where in the code the multiline entry behavior is defined, nor have I yet traced what code I would have to change to make the behavior a settable entry in the UI preferences. ALL INPUT ON EITHER OF THESE TOPICS IS WELCOMED.

Attachments (1)

pidgin-2.10.9-history-uses-ctrl.patch (4.4 KB) - added by UnixRonin 5 years ago.
Patch to gtkconv.c to make unmodified Up/Dn? recall history

Download all attachments as: .zip

Change History (1)

Changed 5 years ago by UnixRonin

Patch to gtkconv.c to make unmodified Up/Dn? recall history

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!