Opened 5 years ago

Last modified 3 years ago

#16305 new patch

Play sound on incoming call (ring tone)

Reported by: poorman Owned by: Maiku
Milestone: Patches Needing Review Component: Voice and Video
Version: 2.10.9 Keywords: ring ringtone
Cc:

Description

Hello folks,

I'm attaching simple patch, which will play sound event on incoming call. It uses the pidgin/libpurple standard way of playing sound events, i.e. sound is played just once and it is not terminated after call is answered.

By default alert.wav is used, but user is free to change his ring tone by standard means in Pidgin configuration (Tools->Preferences->Sounds->Incoming call). This sound event is enabled by default. I personally use real phone ring sound with reasonable length, so it gets my attention, but it finishes before the call is answered.

There is an improvement ticket for this feature: https://developer.pidgin.im/ticket/15713

Cheers, poorman

Attachments (1)

ring.patch (2.6 KB) - added by poorman 5 years ago.
Ring on incoming call (diff -u) patch

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by poorman

Ring on incoming call (diff -u) patch

comment:1 Changed 5 years ago by Robby

  • Milestone set to Patches Needing Review

comment:2 Changed 3 years ago by EionRobb

Ticket #16855 has been marked as a duplicate of this ticket.

comment:3 Changed 3 years ago by MarcMarin

Hello, I applied your patch but I have one question. If I add a custom sound it plays the sound also when I accept the call. How can I modify the code so that the ring will be interrupted during accepting the call?

comment:4 Changed 3 years ago by salinasv

  • Component changed from unclassified to Voice and Video
  • Owner changed from EionRobb to Maiku

comment:5 Changed 3 years ago by poorman

Hello,

I've written in the patch description, that sound is not interrupted after the call is answered. This is acceptable only in case, that short ring tone is chosen.

At time of the patch creation, I was not able to find a simple way, how to terminate a sound, which is being played by libpurple at the background. It would require a more complex changes.

However it has been 19 months ago, so it is possible that situation has changed in current pidgin architecture.

comment:6 Changed 3 years ago by salinasv

Pidgin does not have yet a way to stop a sound. That will be a good addition to the API to get VV working.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!