Opened 4 years ago

Closed 4 years ago

#16526 closed patch (fixed)

Support for notifications for system messages

Reported by: yath23 Owned by:
Milestone: 2.10.12 Component: plugins
Version: 2.10.11 Keywords:
Cc:

Description

When Pidgin is showing a system message, like from the OTR plugin “The following message received from foo was not encrypted: [bar]"”, no notification is generated, causing the user to miss those messages if he leaves his chat/IM window open.

This patch adds support for notifications for IM and/or chat windows (toggleable in the plugin preferences). This is basically a workaround for Defect #14874.

This patch is against the release tarball of 2.10.11 as hg clone didn't finish after nearly an hour, sorry.

Attachments (2)

pidgin-2.10.11.notify-system.patch (4.3 KB) - added by yath23 4 years ago.
pidgin-hg4432aff3b90d.notify-system.patch (4.1 KB) - added by yath23 4 years ago.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by yath23

Changed 4 years ago by yath23

comment:1 Changed 4 years ago by yath23

So hg clone eventually finished; I’ve added a patch against the latest head(?).

comment:2 Changed 4 years ago by datallah

  • Milestone set to Patches Needing Review

Can you supply your name as you'd like to be attributed in the COPYRIGHT file?

comment:3 Changed 4 years ago by yath23

Sure, “Sebastian Schmidt <yath [at] yath.de>” is fine (the “[at]” being an actual @, of course, but I’m not sure whether Trac redacts that).

comment:4 Changed 4 years ago by yath23

Friendly ping.

comment:5 Changed 4 years ago by Sebastian Schmidt <yath@…>

  • Milestone changed from Patches Needing Review to 2.10.12
  • Resolution set to fixed
  • Status changed from new to closed

(In [7e315013fb73]):
notify: Add support for notifications for system messages

Very minor tweaks from Daniel Atallah

Fixes #16526

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!