Opened 4 years ago

Closed 4 years ago

#16667 closed defect (fixed)

Crazy Chat in main Pidgin tree

Reported by: mmcco Owned by: EionRobb
Milestone: 3.0.0 Component: unclassified
Version: 2.10.11 Keywords:
Cc:

Description

Recently, I was idly grepping around the pidgin/main repo to see where and how randomness was accessed. I came across a use of /dev/random (considered bad practice) in pidgin/plugins/crazychat/cc_network.c, which I mentioned on devel@.

It turns out that no one knew Crazy Chat was in the main source, and many had never heard of it. Some doubted that it had been compiled by default for years. Searching developer.pidgin.im for it turns up almost nothing, just a couple bugs related to bad coding practice in the plugin.

This seems to be the corresponding chat service: http://www.crazy-chat.net/ They mention supporting access via IRC.

The general consensus seemed to be that it should be removed. Thoughts? I doubt anyone uses it, and it seems completely dormant and abandoned.

Change History (5)

comment:1 Changed 4 years ago by mmcco

Ethan said it looks risky to leave, especially with webcam access, pthreads, OpenGL, etc. There seems to be a consensus on removing it.

grep -Rin crazychat in the repo's root dir didn't return anything outside of the crazychat dir. There may be Crazy Chat-specific libraries required in the configure scripts, though. That's the next check necessary before actually axing it.

comment:2 Changed 4 years ago by mmcco

The current 3.0 repo tip (changeset 37186) build and runs if you simply rm -rf pidgin/plugins/crazychat. I'm now looking for any additional cleanup that can be done as a result of this. It's probably a good idea to commit the directory removal in the meantime. Thoughts?

comment:3 Changed 4 years ago by mmcco

Directory removal committed (changeset 37187).

comment:4 Changed 4 years ago by mmcco

Apparently, this was an unsuccessful GSoC project from 2005. This was back when the project used CVS, so there was no proper branching and the students had to commit in-tree. So, it's likely that this code was never completed.

We briefly looked for remaining dependencies but couldn't find any. This ticket can probably be closed as fixed.

comment:5 Changed 4 years ago by Robby

  • Milestone set to 3.0.0
  • Resolution set to fixed
  • Status changed from new to closed

Let’s do that then. :-)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!