Opened 4 years ago
Closed 3 years ago
#16747 closed defect (fixed)
History plugin shows smileys in timestamp
Reported by: | computergeoffrey@… | Owned by: | |
---|---|---|---|
Milestone: | 2.10.12 | Component: | plugins |
Version: | 2.10.11 | Keywords: | |
Cc: | igor.g |
Description
The history plugin shows smileys in a timestamp when they match the smiley character sequence. For example, with the Facebook smileys installed (includes :3): 10:30:30 becomes 10 smiley 0 smiley 0 instead of 10:30:30
Attachments (1)
Change History (9)
comment:1 Changed 4 years ago by computergeoffrey@…
comment:2 Changed 4 years ago by Robby
- Cc igor.g added
comment:3 Changed 4 years ago by mmcco
However, 3.0 uses WebKit/WebView? and apparently needs a more involved solution.
comment:4 Changed 4 years ago by salinasv
mmcco does that disable smileys for the whole message?
comment:5 Changed 4 years ago by mmcco
No. options is declared at the top:
GtkIMHtmlOptions options = GTK_IMHTML_NO_COLOURS;
Unless I'm missing something major, my diff pretty clearly only appends the header. The g_strdup_printf() call shows that it's just that line. The body is rendered afterward:
g_strchomp(history); gtk_imhtml_append_text(GTK_IMHTML(gtkconv->imhtml), history, options); g_free(history); gtk_imhtml_append_text(GTK_IMHTML(gtkconv->imhtml), "<hr>", options);
On a separate note, I don't actually think that this is a problem for Pidgin 3. I've never noticed it myself. That said, 3.0's History plugin has bigger issues at the moment...
comment:6 Changed 4 years ago by mmcco
I just tested this patch on 2.10.11 and it's working for me.
I'll ask if this should be committed. It should make it into 2.10.12.
comment:7 Changed 3 years ago by computergeoffrey@…
mmcco, did you get my e-mail?
It would be nice to see this committed (and released). Thank you already.
Is there any roadmap or target date for the release of 2.10.12?
comment:8 Changed 3 years ago by Michael McConville <mmcconville@…>
- Milestone set to 2.10.12
- Resolution set to fixed
- Status changed from new to closed
(In [b4e5abab1114]):
Don't render smileys in the History plugin's headers. Fixes #16747
Please note that a $15 bounty is available for this bug. https://www.bountysource.com/issues/25950566-history-plugin-shows-smileys-in-timestamp