Opened 20 months ago

Closed 16 months ago

Last modified 16 months ago

#16762 closed patch (fixed)

Don't remove transient startup status from saved_statuses

Reported by: haakon Owned by:
Milestone: 2.10.12 Component: libpurple
Version: 3.0.0hg Keywords: startup status
Cc:

Description

It was possible for a transient saved status that was also set as the startup status to get removed on shutdown, when libpurple calls remove_old_transient_statuses(). Consequently, when the client was started next time, its status got incorrectly set to the last 'current' status instead.

We should always keep startup status in the list of saved statuses, same as we do with current status.

This could happen with Pidgin when user selected some of the pre-filled primitive statuses from the combo box at Preferences > Status / Idle (Pidgin may create a new transient status for such selected item in gtksavedstatuses.c:status_menu_cb()).

This patch should be applicable to both 'release-2.x.y' and 'default' branches.

Though the description is pretty vague, it appears that it also fixes defect #14758.

Attachments (1)

0001-Don-t-remove-transient-startup-status-from-saved_sta.patch (2.1 KB) - added by haakon 20 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 20 months ago by salinasv

  • Milestone set to Patches Needing Review

comment:2 Changed 16 months ago by Jakub Adam <jakub.adam@…>

  • Milestone changed from Patches Needing Review to 2.10.12
  • Resolution set to fixed
  • Status changed from new to closed

(In [968ef3b0caed]):
Fix #16762 where transient startup statuses could be deleted on exit

comment:3 Changed 16 months ago by Jakub Adam <jakub.adam@…>

  • Milestone changed from 2.10.12 to 3.0.0

(In [78d036e70f8e]):
Fix #16762 where transient startup statuses could be deleted on exit

comment:4 Changed 16 months ago by Robby

  • Milestone changed from 3.0.0 to 2.10.12
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!