Opened 3 years ago

Closed 21 months ago

Last modified 16 months ago

#17061 closed patch (fixed)

libpurple: hmac() conflicts with NetBSD's libc hmac()

Reported by: _wiz_ Owned by:
Milestone: 2.13.0 Component: libpurple
Version: 3.0.0hg Keywords:
Cc:

Description

libpurple/protocols/jabber/auth_scram.c includes a function called hmac() (latest release and mercurial from today). NetBSD (since a short while) has a hmac() function in its libc, with a different calling convention, which breaks the build, see http://netbsd.gw.com/cgi-bin/man-cgi?hmac++NetBSD-current

Attachments (1)

patch-libpurple_protocols_jabber_auth__scram.c (1.7 KB) - added by _wiz_ 3 years ago.
Patch renaming hmac to purple_hmac, fixing the build.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by _wiz_

Patch renaming hmac to purple_hmac, fixing the build.

comment:1 Changed 3 years ago by Robby

  • Milestone set to 3.0.0

comment:2 Changed 21 months ago by dx <dx@…>

  • Milestone changed from 3.0.0 to 2.10.13
  • Resolution set to fixed
  • Status changed from new to closed

(In [1e7a57174d26]):
jabber/auth_scram: prefix the names of the 'hmac' and 'hash' functions

Trac ticket #17061 says that netbsd added a function called hmac to its libc.

These are private (static) functions so it's safe to rename them. Also renaming the hash function just in case.

Fixes #17061

comment:3 Changed 21 months ago by Robby

Thanks for the report, _wiz_! Another 3.0 ticket down… :-)

comment:4 Changed 21 months ago by Robby

  • Milestone changed from 2.10.13 to 2.12.1

Post-commit hook needs work.

comment:5 Changed 16 months ago by Robby

  • Milestone changed from 2.12.1 to 2.13.0
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!