#17238 closed defect (fixed)

Finch search results don't clear on update

Reported by: dwmw2 Owned by: sadrul
Milestone: 2.13.0 Component: finch (gnt/ncurses)
Version: 2.12.0 Keywords:
Cc:

Description

$ grep -A6 ^finch_notify_sr_new_rows gntnotify.c
finch_notify_sr_new_rows(PurpleConnection *gc,
		PurpleNotifySearchResults *results, void *data)
{
	GntTree *tree = GNT_TREE(data);
	GList *o;

	/* XXX: Do I need to empty the tree here? */

Yes, you do ;)

I implemented a PRPL which shows users' status in search results and uses purple_notify_searchresults_new_rows() when it updates. But every time, Finch just appends the new results to the old ones:

┌────────────────┤User autocomplete├───────────────┐
│Search results                                    │
│┌───────────────┬───────────────┬────────────────┐│
││Name           │Email          │Availability    ││
││───────────────┼───────────────┼────────────────││
││Woodhouse, Dav…│dwmw@amazon.co…│Busy            ││
││Woodhouse, Dav…│dwmw@amazon.co…│Available      ▒││
││Woodhouse, Dav…│dwmw@amazon.co…│Busy           ▒││
││               │               │               ▒││
││               │               │               ▒││
││               │               │                ││
│└───────────────┴───────────────┴────────────────┘│
│                   ┌─────┐ ┌────┐                 │
│                   │ Add │ │ IM │                 │
│                   └─────┘ └────┘                 │
└──────────────────────────────────────────────────┘

This works correctly in Pidgin. (Btw it'd be really nice to be able to display their status as an icon like in the buddy list, rather than just text. But that's a request for another day...)

Change History (4)

comment:1 Changed 19 months ago by Robby

  • Milestone 2.12.1 deleted

comment:2 Changed 18 months ago by dwmw2

It also never calls the close callback that my PRPL set for the search results, so it also crashes when the next update comes in after I close the window. Patch forthcoming as soon as I've done the necessary internal bureaucracy for it.

comment:4 Changed 16 months ago by Robby

  • Milestone set to 2.13.0
  • Resolution set to fixed
  • Status changed from new to closed

Pull request merged.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!