Opened 16 months ago

Last modified 11 months ago

#17280 new patch

HTML log files invalid

Reported by: stars Owned by:
Milestone: Patches Needing Review Component: libpurple
Version: 2.12.0 Keywords: html, log
Cc:

Description

I normally use plaintext logging, but I decided to try HTML logs. The HTML logs have no doctype, and use H3 instead of H1 for the header. There are other odd things, like text in the body without being in a proper element, and XHTML <br/> when it's an HTML document, thus really needing to be HTML <br>. Also, the use of the deprecated <font> element instead of CSS. That's all fixed in this attached diff. I confirmed the new logs look identical to the old logs in Firefox and Chrome, except for the header size. Now, the logs are valid HTML.

Attachments (1)

htmllog.diff (5.4 KB) - added by stars 16 months ago.
diff of log.c in the libpurple directory in pidgin 2.12.0 source code

Download all attachments as: .zip

Change History (6)

Changed 16 months ago by stars

diff of log.c in the libpurple directory in pidgin 2.12.0 source code

comment:1 Changed 15 months ago by stars

Ping. The diff is there. Bugs after this have been given ownership. This could be quickly and easily committed.

comment:2 Changed 14 months ago by strangeways

  • Milestone set to Patches Needing Review
  • Type changed from enhancement to patch

comment:3 Changed 14 months ago by strangeways

This is now tracked as a Bitbucket PR : https://bitbucket.org/pidgin/main/pull-requests/312/ . Thank you for your contribution.

comment:4 Changed 11 months ago by stars

I'm working on a redo of this patch: I should have the h1 problem noted in the bitbucket thread solved soon, among other fixes I noticed on my own more recently.

comment:5 Changed 11 months ago by strangeways

Thanks. I'm totally swamped with other stuff right now and really can't spare any time for this.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!