Handle NetworkManager disconnection notices better.

[chiefbutz]

I am currently using Ubuntu 6.10, and Gaim2 beta 6. I have found a few problems with the contact list. When I am not connected to the internet it still displays people, and it doesn't always update when I get connected to the internet again.

[lschiere]

what protocols are you using?

[chiefbutz]

I use AIM, ICQ, Yahoo, MSN, and Jabber. The problem mainly effects AIM

[chiefbutz]

This problem does also effect Yahoo, MSN, and Jabber. This problem however does not exist when I use windows. Just thought I might add that.

[MarkDoliner]

Fixing our use of NetworkManager should fix this.

[yelo3]

the same thing happens when using pidgin beta 7.

[PierreOssman]

The constant changing of milestone is not that comforting... :/

Can't you have some logic where if the connection has been down for x minutes (wall time, as suspend is a common scenario), then assume the connection is dead. You should also try to check if the ip the socket is bound to is still valid.

[erpo41]

I'm having a problem that could probably be added as a comment to this bug report. When I suspend my laptop at school, take it home, and resume it, gaim still thinks I'm connected to my IM networks, but messages people send to me get lost. Manually changing gaim from available to disconnected and back to available seems to make it work again.

Oh, and I'm not using NetworkManager for my wireless network connections. I'm using wicd.

[seanegan]

Duplicate of #179

[yelo3]

I attached a patch that fixes the problem: when network manager says that we are disconnected, pidgin will disconnect all accounts. and when network manager says we are connected again, pidgin will automatically reconnect.

[yelo3]

PS: I cannot understand why pidgin should send keepalive if the network is down... maybe the patch can remove more code lines, as no additional information is needed to disconnect the account!

[yelo3]

I think this bug is not a duplicate of #179, since it has nothing to do with the new port to dbus... The problem is just that pidgin sends keepalive if the network is down, instead of disconnecting, as it does windows live messenger.

[MarkDoliner]

With the attached patch... what happens if you move from a wireless network to a wired network with a static configuration?

[yelo3]

I don't really know.. can you try it?

[yelo3]

What I can test is this (I only have one cabled connection) connect with network manager, remove the card from network manager list, and then manually configure the card with gnome-config. (I run ubuntu)

in this case my patch works.

[rlaager]

yelo3: I don't understand what problem you're trying to fix. If the network is down and we call the keepalive function, the prpl's keepalve should timeout and the account will be disconnected. If the connection isn't really down (because NetworkManager was wrong, we transitioned to a staticly configured network, or the network comes back up before the timeout), we stay connected. Is this NOT working as described?

[PierreOssman]

The problem is that it takes forever before it times out. And in the mean time, the gui looks as if you are still happily connected. So right now, the feature is completely useless. You still have to disconnect and reconnect manually when you switch networks.

[yelo3]

What PierreOssman? said is exactly what happens. prpl never disconnects.

[rlaager]

Replying to PierreOssman:

The problem is that it takes forever before it times out. And in the mean time, the gui looks as if you are still happily connected. So right now, the feature is completely useless. You still have to disconnect and reconnect manually when you switch networks.

Which protocols are you hitting this with?

[PierreOssman]

MSN and ICQ. I only use those two, so no idea about the others, but any TCP connection should be affected.

[rlaager]

After a discussion in #pidgin, I think we have a good idea of what needs to be done here:

(15:26:03) Ethan Blanton (elb): hysteresis can be added to the NM situation (15:26:30) Ethan Blanton (elb): e.g., when we get a connection drop notice, note the time nad set a timer -- if we haven't reassociated with the same IP in a short period of time, *then* disconnect (15:26:38) Ethan Blanton (elb): if we reassociate with a different IP, force disconnect

If you could modify the patch to do this, we could incorporate it.

[yelo3]

notice that it is not enough that the ip is the same, since there is the possibility to have the same internal ip, but different external ip. with internal ip I mean the ip of the lan with external ip I mean the ip of the router in the lan

[trac-robot]

This ticket was closed automatically by the system. It was previously set to a Pending status and hasn't been updated within 14 days.

[yelo3]

This needs to be reopened!!! It is a really important bug! attaching a new workaround patch, that automatically disconnects.

[Darwin Award Winner]

I have this same problem - when I suspend and resume, Pidgin gives no indication that I was ever disconnected, but after the resume, it doesn't reconnect for at least 5 minutes (I'm not sure of the actual amount of time) unless I manually set my status to Offline and then back to Available. During this time, Pidgin appears to be connected, but to everyone else, it looks as if I have logged off.

The same problem happens on a flaky wireless network that is frequently reconnecting, or even a wireless network that has a continuous but flaky connection. I have to toggle the status every time I lose the connection, which also means that I have to notice each time I lose the connection. In the latter case, since the network doesn't even get disconnected, I get absolutely no indication that I was ever disconnected, except that five or ten minutes later the friend I was talking to suddenly IM's me and asks "Where'd you go?"

Incidentally, an easy way to tell if Pidgin is in this pseudo-connected state is to IM yourself. If you don't get your message back, then Pidgin is disconnected but it doesn't know it is.

[jason237]

I run into this problem too, with Yahoo, MSN, AIM, and Google Chat. After I change network connections or suspend/resume, I need to manually disconnect and reconnect, or it will take Pidgin a long time to notice that it needs to reconnect and I lose incoming messages.

[praveengarlapati]

I can confirm the issue on the version 2.3.1 running on Kubuntu Gutsy.

The network changes go undetected in pidgin. Even though there is a disconnect in the network the status of the buddies doesn't change and neither does pidgin show the error that it got disconnected.

To get back to the actual status either you have to quit and reopen pidgin or modify each account to reconnect.

[Zillode]

I confirm this issue too, using Ubuntu Gutsy, pidgin v2.2.1.

I can't receive messages because I get disconnected from the internet sometimes, due to a bad wireless connection. (It automatically reconnects, so surfing works, but msn is still offline (and gui says online). I only notice the disconnection when I try to send a message and then I have to put myself offline and then online again. This is really a nasty problem.

[Sim-on]

similar thing happened to me. i blocked all outgoing internet-transfer with ZoneAlarm? and pidgin dont take any notice. I can send messages and chang status without error, buddys still are "online". using ICQ/MSN/Gadu-Gadu (2.4.1 WinXP)
I waited 3 minutes... nothing changed. pidgin still seems to be online for me.

After reopening the Firewall i get some socket/conncetion-erros of accounts. Messages i send during the last minutes didnt reach anybody.

[yelo3]

I've read the 2.4.2 changelog. This seems to be fixed. Did you try?

[PierreOssman]

I tested 2.4.2 here, and the problem still remains.

[rlaager]

See ​comment 29 for what needs to be done.

[rlaager]

Actually, I've changed my mind. The patch is fine, but as it turns out, that change has already been made (by me nonetheless). It was in 2.4.2. If this is *NOT* fixed in 2.4.2, please file a *NEW* bug report. Please note the version, whether you use NetworkManager, and what type of network connectivity you have.

[kc9bcy]

4 years? Hmm. Still not fixed, yet closed, on every re-incarnation of this problem. Hell, this is even a different operating system.

[intika]

Pidgin have a serious lack when it comes to notifying the connection state, when network is down, an account is no more connected or when any network error happen.

In the default behavior, pidgin will always show the connected tray icon instead of showing a different icon like other IMs.

This patch/version workaround show the "away" icon when any network icon happen. It’s a usable workaround awaiting dev to add the feature.

​https://github.com/intika/Pidgin_Notify_Disconnected_To_Tray_Icon