Opened 10 years ago

Closed 8 years ago

#2111 closed patch (fixed)

Handle Left and Right arrow keys on Buddy List

Reported by: fmoo Owned by:
Milestone: 2.6.0 Component: pidgin (gtk)
Version: 2.0.2 Keywords: treeview, buddy list, keyboard, left, right
Cc: frasten

Description

When the buddy list (treeview) has focus, pressing left/right should have the following functionality:

  • If a 'Collapsed group' is selected
    • Left should do nothing
    • Right should expand the group.
  • If an 'Expanded group' is selected
    • Left should collapse the group
    • Right should select the first item inside the group (if one is present)
  • If a 'Contact' is selected
    • Left should select the Group node
    • right should do nothing(*)
  • If an 'Expanded contact' is selected
    • Left should collapse the contact
    • Right should select the first buddy inside the contact
  • If a 'Buddy (sub-contact)' is selected
    • Left should select the Contact
    • Right should do nothing.

(*) - Making this expand the contact might be really nice

Attachments (2)

gtkblist-arrows-expandcollapse-2111.patch (2.4 KB) - added by fmoo 10 years ago.
According to ticket; right on contact will expand.
gtkblist-arrows-expandcollapse-2111-updated.patch (2.6 KB) - added by frasten 8 years ago.
Fixes the "beep" issue.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by fmoo

I botched the WikiFormatting again. Awesome

Changed 10 years ago by fmoo

According to ticket; right on contact will expand.

comment:2 Changed 10 years ago by fmoo

Though: I thought this functionality was native to the GtkTreeview? ... and that it was in a previous version of gaim. Anybody know?

comment:3 Changed 9 years ago by chemistrydioxide

When using left or right keys, Pidgin is beeping. In the regular unpatched version, this is understandable because they don't work. But in the patched version, Pidgin beeps every time I hit right or left, whether it made sense or not. Pidgin should only beep if collapsing or expanding is not possible.

comment:4 Changed 9 years ago by datallah

  • Type changed from enhancement to patch

comment:5 Changed 9 years ago by rekkanoryo

Has there been any work on chemistrydioxide's issue in this patch?

Changed 8 years ago by frasten

Fixes the "beep" issue.

comment:6 Changed 8 years ago by frasten

I've edited the patch, now it doesn't beep anymore when expanding/collapsing. Now it should be OK.

comment:7 Changed 8 years ago by deryni

  • Milestone set to Patches Needing Review

comment:8 Changed 8 years ago by rlaager

(14:38:25) rlaager: fmoo: Why are you Fmoo in the about box and not fmoo? (14:39:38) rlaager: fmoo: More importantly, regarding #2111, why do we want code to make the arrow keys behave in that way? Assuming the feature itself is justified, the code in the updated patch seems good to commit. I haven't tested it to verify that it actually works, but it looks correct. :)

comment:9 Changed 8 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to 2.6.0

Accepting, rejecting, or requesting improvement of this patch is a blocker for the release of version 2.6.0.

comment:10 Changed 8 years ago by QuLogic

Will commit later today or tomorrow if nobody else does.

comment:11 Changed 8 years ago by qulogic@…

  • Resolution set to fixed
  • Status changed from new to closed

(In 0f35cd33aa18c3505d499dd84b75cce0a66f3988):
Apply patch from Peter to handle the left and right arrow keys in the buddy list to expand and contract groups or contacts, plus a few leak fixes.

Fixes #2111.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!