Opened 12 years ago

Closed 7 years ago

#2497 closed patch (fixed)

Offline message should indicate that it's a pounce

Reported by: omegatron Owned by:
Milestone: 3.0.0 Component: pidgin (gtk)
Version: 2.1.0 Keywords:
Cc:

Description

Offline Message Emulation is designed to simulate an offline message for IM services that don't support them natively. Of course this means that people on those services aren't familiar with such messages, either, and therefore misinterpret them as live, deliberate messages.

Pounced offline messages should prepend something like "Pounce:" or "Offline message:" to the offline messages. Something clear and concise would be best.

Attachments (2)

offlinemsg-diff.c (1.2 KB) - added by fanton 7 years ago.
This should do the trick.
offlinemsg.patch (1.4 KB) - added by fanton 7 years ago.
Fixed memory leak.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 12 years ago by datallah

  • Type changed from defect to enhancement

comment:2 Changed 12 years ago by shreevatsa

Isn't this an issue with the plugin and not with Pidgin?

comment:3 Changed 12 years ago by omegatron

Don't ask me. I submitted it here as requested on http://plugins.guifications.org/trac/ticket/323

On further thought, I think it should preface with "Offline message" on its own line, so something like this:

Username: ---- Offline message ----

Username: yeah I agree with that

Username: oh you signed off

Username: --------

comment:4 Changed 11 years ago by omegatron

Is anyone going to work on this? It's really annoying when people think I have said something to them but it was actually a response to something they said hours or days before, especially if I'm not actually at the computer when they come online, etc.

comment:5 follow-up: Changed 11 years ago by deryni

I don't know anyone actively working on this (not that it requires much work) but patches are always welcome (and much quicker/easier to apply and test then to sit down to write in the first place). I'm sure it will be gotten to eventually by someone, but if you have the time, the desire, and the ability you will almost certainly get to it fater.

comment:6 in reply to: ↑ 5 Changed 11 years ago by omegatron

Replying to deryni:

patches are always welcome

Easy for you to say. :) I can't even successfully compile a package from source, let alone write code for a patch.

This seems like a relatively simple thing to implement, though. Just need to decide on the exact wording/formatting and then make the message pop up along with the pounce. I'm curious as to how an automatic away message is formatted in AIM to display with a qualifier before the message itself:

(3:12:39 AM) username <AUTO-REPLY> : away message

Maybe we could do the same thing with these packets to make a similar message for offline pounces.

comment:7 follow-up: Changed 11 years ago by deryni

The problem with such tagging (and the reason pidgin doesn't send auto-away messages on protocols that don't support it natively) is that they become translation annoyances and that even given a proper translation they confuse people who don't expect their protocol to be doing that. Which, I might point out, is exactly the problem you are trying to solve in the offline message emulation plugin. And yes, adding the message itself is not hard, it is the rest of the stuff that is frought with problems (namely the above problem).

comment:8 in reply to: ↑ 7 Changed 11 years ago by omegatron

Replying to deryni:

Well it doesn't have to be tagged like that as an auto-reply. It can just be done with regular IM messages, like the idea I suggested on 12/05/2007. Send the offline message as currently done, but preface it with a regular IM message that tells the recipient "the following is an offline pounce" and another saying "this is the end of the offline messages".

comment:9 Changed 11 years ago by deryni

That is tagging, it is just tagging with an extra message instead of with an extra message bit. What does the offline message emulation plugin if you choose not to have it set a pounce? Does it let you edit your message and then try to send again (and prompt you again)? Assuming you have prompting turned on that is.

comment:10 Changed 10 years ago by bernmeister

Set to pending?

comment:11 Changed 10 years ago by deryni

  • Milestone set to Patches welcome

Changed 7 years ago by fanton

This should do the trick.

Changed 7 years ago by fanton

Fixed memory leak.

comment:12 follow-up: Changed 7 years ago by MarkDoliner

fanton: Was there a reason for moving those lines of code down below the purple_conversation stuff? This patch looks good to me.

I'm wondering if "Offline message" is the most ideal string. Remember that it should make sense to the person receiving the message. And there's maybe a 50% chance they'll receive it immediately after signing on. Can people express opinions about the follow strings (or suggest others)?

  1. Delayed message
  2. Postponed message
  3. Offline message
  4. Queued message

(I listed them in my preferred order.)

comment:13 Changed 7 years ago by MarkDoliner

  • Milestone changed from Patches welcome to Patches Needing Review
  • Type changed from enhancement to patch

comment:14 in reply to: ↑ 12 Changed 7 years ago by fanton

The reason for moving those lines was that before the last patch, the sender would've seen the string "Offline message" even when he actually sends the message. Now, i thing it should work even without moving them, because the message sent to the pounce it's a copy of the original one. I can move them back, if you think so.

comment:15 Changed 7 years ago by MarkDoliner

fanton: Ahh, I see. Thanks. Don't worry about moving them back... I can do that (it doesn't actually matter, but all things being equal I prefer to make as few changes as possible). Do you have any preference on the wording?

comment:16 Changed 7 years ago by MarkDoliner

fanton: Oh, and do you have a name we should use for you in our COPYRIGHT file?

comment:17 Changed 7 years ago by fanton

I don't know what to say about the text that should be used. Imho "Offline message" seems ok. My name is Flavius Anton if you want to use it in the © file. Thanks.

comment:18 Changed 7 years ago by Robby

Agreed, I think most users are familiar with the term "offline message".

comment:19 Changed 7 years ago by MarkDoliner

Cool, thanks. I committed this to im.pidgin.pidgin, which will eventually get released as 3.0.0.

comment:20 Changed 7 years ago by markdoliner@…

  • Milestone changed from Patches Needing Review to 3.0.0
  • Resolution set to fixed
  • Status changed from new to closed

(In a6a5be7291d88240cd7a6b7034ac9942d5bfba4b):
The Offline Message Emulation plugin now adds a note that the message was an offline message. (Flavius Anton) (fixes #2497)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!