Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2606 closed patch (fixed)

Fix for #1384, (Sending "gone" notifications in IMs)

Reported by: bobbybrasko Owned by:
Milestone: 2.1.1 Component: libpurple
Version: 2.1.0 Keywords:
Cc:

Description

Hi,

It bothered me that pidgin was alerting others when I shut my window. So, I created a small patch that only sends the "gone" notification if the "Notify buddies that you are typing to them" options is checked. If it's not checked, the "gone" message is not sent, and the user on the other side does not see "so and so has left the conversation"

Please apply this patch. The file is a patch to pidgin-2.1.0/libpurple/protocols/jabber/message.c.

Attachments (1)

message.c.diff (441 bytes) - added by bobbybrasko 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by bobbybrasko

comment:1 Changed 9 years ago by seanegan

  • Resolution set to fixed
  • Status changed from new to closed

Accepted for 2.1.1

Thanks!

comment:2 Changed 9 years ago by seanegan

  • Milestone set to 2.1.1

comment:3 Changed 7 years ago by himdel

This patch is wrong and you might want to consider reverting it.

Typing notification has *nothing* to do with closing conversation notification. Plus, closing window conversation is XMPP specific while the typing notification option can't be set per-account or even per-protocol.

Also, this patch was meant to fix #1384, which it didn't, and #1384 is fixed properly now (via persistent conversations).

Would there be interest for a patch that: a) reverts this b) adds a proper "send gone" option to:

  1. Preferences/Conversation?
  2. (XMPP)Account/Advanced?/XMPP Options

? If so, please specify the preference between b1 and b2 and I'll sent it right in.

Because this thing really bugs me, sorry. (And bobby, please I mean no offense, I do understand it was a quick and easy way to make it possible not to send the gone notifications.)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!