Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#3264 closed defect (fixed)

Custom smileys in MSN chats not working

Reported by: aythun Owned by: QuLogic
Milestone: 2.5.0 Component: MSN
Version: 2.2.0 Keywords: msn chat custom emoticons smileys
Cc:

Description

In MSN chats, when someone sends a custom smiley, only the text code of it is displayed, and a blank conversation window with that user is opened in the background. This doesn't happen in MSN conversations with a single user; custom smileys behave as expected.

Change History (9)

comment:1 Changed 11 years ago by salinasv

I will take a look.

comment:2 in reply to: ↑ description Changed 11 years ago by malu

Replying to aythun:

In MSN chats, when someone sends a custom smiley, only the text code of it is displayed, and a blank conversation window with that user is opened in the who = msn_object_get_creator(obj);

sha1 = msn_object_get_sha1(obj);

slplink = msn_session_get_slplink(session, who);

background. This doesn't happen in MSN conversations with a single user; custom smileys behave as expected.

I see the following lines in slp.c (msn_emoticon_msg):

		who = msn_object_get_creator(obj);
		sha1 = msn_object_get_sha1(obj);

		slplink = msn_session_get_slplink(session, who);

		conv = purple_find_conversation_with_account(PURPLE_CONV_TYPE_ANY, who,
												   session->account);

/* comments here... */

		if (!conv) {
			conv = purple_conversation_new(PURPLE_CONV_TYPE_IM, session->account, who);
		}


I'm not that familiar with the MSN parts, but it seems to me that "who" of the object is the user sending the smiley, whereas the current conversation would be that of the chat. So I assume a new conversation gets spawn (if there isn't a coversation with that buddy open). So I guess it would have to be "redirected" to the conversation of the chat...

comment:3 Changed 11 years ago by kasmol

Yes also to me

comment:4 Changed 11 years ago by QuLogic

  • Owner changed from khc to QuLogic

comment:5 Changed 11 years ago by qulogic@…

(In 2081dc33bc0657496c17f737f0f6d2f54479c246):
When receiving an MSN custom smiley, look at the switchboard for the PurpleConversation?, instead of searching for it. This should make receiving a smiley in a chat go to the chat window, instead of opening a new conversation with the buddy.

References #3264.

comment:6 Changed 11 years ago by QuLogic

  • Resolution set to fixed
  • Status changed from new to closed

In e56d7c10f8cc1dc7085e856b4028be46df81d9bd:

MSNP15 is here! Hopefully I didn't break anything. Sorry for the ton of mail here.

Fixes #3264. Fixes #3939. Fixes #4332. Fixes #4339. Fixes #4875
Fixes #4877. Fixes #5379. Fixes #5545. Fixes #5984. Fixes #6210.
Fixes #6257. Fixes #5212, I hope.
Somewhere or other, this also fixes #4876.

comment:7 follow-up: Changed 11 years ago by robochief

This still happens in MSN chat windows; a new conversation opens with one of the chat members.

comment:8 in reply to: ↑ 7 Changed 11 years ago by QuLogic

  • Milestone set to 2.5.0

Replying to robochief:

This still happens in MSN chat windows; a new conversation opens with one of the chat members.

With a smiley or just a random open window?

comment:9 Changed 11 years ago by robochief

Just randomly, not necessary a [custom] smiley. As this seemed to be fixed (and closed all duplicate tickets), I'm posting here.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!