Opened 11 years ago

Last modified 10 years ago

#3267 new task

Replace PluginPref API with Request API

Reported by: rekkanoryo Owned by: sadrul
Milestone: 3.0.0 Component: libpurple
Version: 2.2.0 Keywords:
Cc:

Description

According to a comment on the AfterTwoOhOh wiki page:

There's some amount of duplication between the PluginPref API and the Request API. This should be fixed. Finch currently converts a PluginPref frame into a RequestFields (gntplugin.c:process_pref_frame), which allows it to reuse the Request API's UI. Each name and label of a PluginPref maps one-to-one with a RequestField. However, a PluginPref can impose some restrictions on a value (eg. min/max values for an integer preference), which a RequestField still can't do. So some additions to the Request api will be necessary.


If we really want to do this, I would suggest that we add a _with_limits function to each request field type that needs it. This would allow us to make a transition in 2.x by making PluginPref be a wrapper for Request, and then at 3.0.0 we can kill PluginPref and rename the _with_limits functions to replace their predecessors.

Change History (3)

comment:1 Changed 11 years ago by rekkanoryo

  • Type changed from patch to task

I specifically selected "task" when I started this ticket...

comment:2 Changed 11 years ago by sadrul

  • Summary changed from Replace !PluginPref API with Request API to Replace PluginPref API with Request API

comment:3 Changed 10 years ago by sadrul

We can also replace AccountOption with Request, I think.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!