Opened 12 years ago

Closed 11 years ago

#3305 closed defect (fixed)

MSNP14 shows hotmail contacts as MSN Messenger contacts.

Reported by: Karma_Police Owned by: khc
Milestone: 2.4.1 Component: MSN
Version: Keywords: MSNP14 hotmail patch
Cc:

Description

I have the latest monotone version, with the MSN merge, and I am using pidgin with an hotmail address.

The latest windows live messenger (and I am guessing it has something to do with an upgrade to hotmail for a better integration between the two, so it should only affect @hotmail and @msn users) shows "Non-Instant Messaging Contacts" in the contact list (which the user can group under a group with that name), which are the hotmail contacts. Some of them can also be messenger users, but live messenger does not show their status.

With the latest MSN merge however, those contacts are displayed in pidgin as normal contacts, complete with status, the msn name, personal message and buddy icon.

Removing them from pidgin seems to have some impact on the contacts in hotmail, since when I try to view one I get: "This contact can't be changed because it has already been deleted." when hotmail was open, and they disappeared when I reopened hotmail.

When I remove a messenger contact it also removes it from the hotmail contact list, which is also not the desired behavior.

When pidgin is retrieving the groups we can see:

(11:25:26) MsnAB: group_id:1983 name:Other Contacts
(11:25:26) MsnAB: group_id:email name:Non-IM Contacts

Which seems to indicate an easy way to identify the contacts in question, but they seem to be recognized as being in the other groups only:

(11:25:26) MsnAB: passport:{XXX@XXX.XXX} uid:{XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXX} display:{XXX@XXX.XXX}
(11:25:26) MsnAB: parse guid...
(11:25:26) User: group id:1983,name:Other Contacts,user:XXX@XXX.XXX

Since users don't have these as contacts in MSN Messenger for a reason or another, I think the desired behavior would be to either hide those contacts (as it is done in pidgin 2.20) or mimic messenger live, and have an option to group and/or hide those contacts.

Attachments (1)

pidgin-msnp14-ignore-non-messenger-contacts.diff (1.1 KB) - added by Maiku 11 years ago.
Ignores non-messenger contacts

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by Karma_Police

I've been looking in the soap responses and the contact seems to have a "isMessengerUser" field.

<isMessengerUser>true</isMessengerUser>

Which is true for messenger users, and false for email contacts (obviously). So maybe a fix would be to ignore contacts where <isMessengerUser> is false, since trying to do the same as messenger live (show/hide and group hotmail contacts) would probably be impossible without messing with libpurple, as I am not sure if other protocols have something similar.

PS: The reason I filled this bug is because I think it may confuse some users to have contacts suddenly appear on their contact list, without authorization requests. I don't think it is just a cosmetic issue of having unwanted cruft on the contact list.

comment:2 Changed 11 years ago by Maiku

I checked the code for this issue and found that there is already an if statement in there to handle this, but there's no actual code. It has:

/*TODO maybe we can just ignore it in Purple?*/
purple_debug_info("MSNAB", "Other type user\n");

If we are going to just ignore those contacts it would be a simple fix. I'll go ahead and make a patch for it if there are no objections.

comment:3 Changed 11 years ago by khc

ya I think we should do that

Changed 11 years ago by Maiku

Ignores non-messenger contacts

comment:4 Changed 11 years ago by khc

  • Keywords patch added

comment:5 Changed 11 years ago by khc@…

  • Milestone set to 2.4.1
  • Resolution set to fixed
  • Status changed from new to closed

(In 01cab96afbc36f21d5b67cb5791b1cf6a0b48920) patch from Maiku to ignore non-messenger contacts, fixes #3305

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!