Opened 11 years ago

Last modified 5 years ago

#3329 new patch

Autocompletion of screennames with spaces

Reported by: k1gwb Owned by:
Milestone: Patches Needing Improvement Component: pidgin (gtk)
Version: 2.2.0 Keywords: tab autocomplete
Cc: mthurman, ahugh

Description

I was in an AIM chat and tried to address someone with the screenname "m o z a". there was someone else in the chat with a screenname starting with m that did not have any spaces formatted into it....myleaderisamonkey for instance.

I hit "M" then tab and it gave me the two choices in gray in the scrollback area, but I could find no way to select the one with the spaces. Perhaps "mo"<tab> could select this one? Parsing the screennames without the spaces for the purpose of tab completion?

Attachments (1)

tab_autocomplete_fix_mtn.diff (1.5 KB) - added by darkrain42 9 years ago.
Patch from #10793 by mthurman

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by lschiere

  • Component changed from unclassified to pidgin (gtk)
  • Owner lschiere deleted

comment:2 Changed 10 years ago by DamienCassou

Hi,

I would also like to see this problem fixed. Most people on IRC do not have a space in their nicknames, but for those who have this is annoying.

Thank you

comment:3 Changed 10 years ago by bernmeister

Is this still an issue in 2.5.8? If so, perhaps this might be best put into Patches Welcome?

comment:4 Changed 10 years ago by darkrain42

  • Keywords aim removed
  • Milestone set to Patches welcome

comment:5 Changed 9 years ago by DamienCassou

Yes, this is still an issue in Pidgin 2.5.8.

Changed 9 years ago by darkrain42

Patch from #10793 by mthurman

comment:6 Changed 9 years ago by darkrain42

  • Milestone changed from Patches welcome to Patches Needing Review
  • Type changed from defect to patch

Patch moved from #10793. Patch is written by Mark Thurman (mthurman -at- gmail DOT com) and Anthony Hugh (ahugh23 -at- gmail DOT com).

comment:7 Changed 9 years ago by darkrain42

  • Cc mthurman added

comment:8 Changed 9 years ago by darkrain42

Ticket #10793 has been marked as a duplicate of this ticket.

comment:9 Changed 9 years ago by sadrul

Replying to patch by mthurman:

This patch fixes the problem with tab completion as outlined in 3329 (a defect). We essentially used the code that was already in the function and just move things around. Being new, we didn't want to change too much but we don't see the need for both temp and nick_partial (even though we kept both).

Since we can assume that entered has no white space, we solved the problem by stripping out spaces from the name we are comparing to. I'm not sure if '\t', '\r', '\n' (etc) are valid in names (I assume not) but they would still not be matched with this code.

This patch is submitted by Mark Thurman (mthurman AT gmail DOT com) and Anthony Hugh (ahugh23 AT gmail DOT com).

The assumption that 'entered' has no white space may not always be correct. For example, if we have two entries 'M Purple' and 'M Pidgin', then there's no way of tab-completing either names with this patch. A cleverer algorithm is needed for this.

comment:10 Changed 9 years ago by darkrain42

  • Milestone changed from Patches Needing Review to Patches Needing Improvement

comment:11 Changed 5 years ago by amantia

This is still present in the 2.10.9 version (I tested only with a Jabber account). If you have a buddy called Foo and another one Foot Bar, you can complete until Foo, but not Foot Bar.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!