Opened 10 years ago

Last modified 2 years ago

#3692 new enhancement

No URI Handler for IRC

Reported by: ronofir Owned by:
Milestone: Patches Needing Review Component: IRC
Version: 2.2.2 Keywords:
Cc: ips

Description (last modified by datallah)

Pidgin doesn't support irc:// URIs internally. This is a request for it to do so (specification).

Attachments (3)

pidgin-irc-uri-handler.c (5.8 KB) - added by EionRobb 3 years ago.
myIrcHandlerOnLibpurple.diff (8.6 KB) - added by belmyst 3 years ago.
Ported the plugin-based patch to libpurple.
add-uri-handler-for-irc.patch (10.4 KB) - added by alex.henrie 2 years ago.
[PATCH] Add URI handler for IRC

Download all attachments as: .zip

Change History (16)

comment:1 Changed 10 years ago by seanegan

  • Component changed from unclassified to IRC
  • Owner changed from lschiere to elb

comment:2 Changed 10 years ago by seanegan

  • Component changed from IRC to winpidgin (gtk)
  • Owner changed from elb to datallah

comment:3 follow-up: Changed 9 years ago by intersol

It would take 5 minute for adding this to the installer.

comment:4 in reply to: ↑ 3 Changed 9 years ago by datallah

Replying to intersol:

It would take 5 minute for adding this to the installer.

This is such a classic response from someone who has no idea what it would take. The fact is that it has nothing to do with the installer - what needs to be done is to implement a parser for this draft RFC in the IRC protocol (or a plugin).

comment:5 follow-up: Changed 9 years ago by intersol

The bug description "it seems that Pidgin can handle IRC links" so it's not related to parsing the url, just the regitry entry. Or maybe the bug description is wrong.

comment:6 in reply to: ↑ 5 Changed 9 years ago by datallah

  • Component changed from winpidgin (gtk) to IRC
  • Description modified (diff)
  • Milestone set to Patches welcome
  • Owner datallah deleted

Replying to intersol:

The bug description "it seems that Pidgin can handle IRC links" so it's not related to parsing the url, just the regitry entry. Or maybe the bug description is wrong.

The original description specified by the reporter was incorrect. I think the purple-url-handler will handle irc:// links, but doesn't do it according to the specification above and isn't at all useful on Windows.

Changed 3 years ago by EionRobb

comment:7 Changed 3 years ago by belmyst

The submitted patch should be something more similar to a3b6446eb2c4b20e5ec7081eba9315928a45490b. Am I correct? I'll try and rework it to be included directly in libpurple instead of as a plugin.

comment:8 Changed 3 years ago by belmyst

Both versions still need a bit of work, though. Options needkey and needpass are parsed, but they have no effect.

Last edited 3 years ago by belmyst (previous) (diff)

Changed 3 years ago by belmyst

Ported the plugin-based patch to libpurple.

comment:9 Changed 3 years ago by Robby

  • Milestone changed from Patches welcome to Patches Needing Review

comment:10 Changed 3 years ago by belmyst

I believe that purple-url-handler also needs patching, as it does not recognise network names (it matches account domain directly to the URI, without checking the isnetwork flag). This applies to both patches.

Changed 2 years ago by alex.henrie

[PATCH] Add URI handler for IRC

comment:11 Changed 2 years ago by alex.henrie

For what it's worth, I've rebased belmyst's patch to work with the latest libpurple.

comment:12 Changed 2 years ago by renatosilva

Belmyst's patch doesn't seem to work well yet. The one from alex.henrie seems based on 3.x.

Last edited 2 years ago by renatosilva (previous) (diff)

comment:13 Changed 2 years ago by renatosilva

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!