Opened 11 years ago
Last modified 10 years ago
#4003 new defect
Accelerator keys are not used consistently
Reported by: | jeffr | Owned by: | deryni |
---|---|---|---|
Milestone: | Patches welcome | Component: | libpurple |
Version: | 2.2.2 | Keywords: | |
Cc: |
Description
There are a number of places where libpurple returns "OK" instead of "_OK", for example. These should all be made consistent.
Change History (6)
comment:1 Changed 11 years ago by deryni
comment:2 Changed 11 years ago by jeffr
Leave it to me :)
comment:3 Changed 10 years ago by bernmeister
jeffr: Any news on this...?
comment:4 Changed 10 years ago by darkrain42
- Milestone set to Patches welcome
All from im.pidgin.pidgin at 18f16a423f835272cdecfadd92ac25f7dfa9ce50
gtkcertmgr.c:195: _("OK"), gtkdialogs.c:754: _("OK"), G_CALLBACK(pidgin_dialogs_im_cb), gtkdialogs.c:893: _("OK"), G_CALLBACK(pidgin_dialogs_info_cb), gtkdialogs.c:985: _("OK"), G_CALLBACK(pidgin_dialogs_log_cb), gtkrequest.c:272: STOCK_ITEMIZE(_("OK"), GTK_STOCK_OK); gtkutils.c:1604: DND_FILE_TRANSFER, "OK", (GCallback)dnd_image_ok_callback, gtkutils.c:1624: "OK", (GCallback)dnd_image_ok_callback, account.c:1158: _("OK"), ok_cb, account.c:1493: _("OK"), G_CALLBACK(change_password_cb),
comment:5 Changed 10 years ago by deryni
Those appear to all be in purple_request_* calls, which translate the text to a Stock ID (that's where the gtkrequest.c line comes from). As such those should all get the correct mnemonics set for them, except for the un-localized versions as the stock-id matching checks localized strings. Which leads me to believe that we should actually stop localizing the text and probably add PURPLE_STOCK_{OK,CANCEL} defines to make this clearer going forward. Seem reasonable?
comment:6 Changed 10 years ago by deryni
- Owner set to deryni
A listing of places or a patch to fix them would be much appreciated.