pidgin-2.3.1 not paying attention to gtkrc pixmap_path

[reiffert]

The motivation as of now can be found here: ​http://pidgin.im/pipermail/devel/2008-March/005012.html

I attached a patch that will correct the behaviour by correcting just a single occurence of loading pixmaps. When you are rebuilding pidgin-2.3.1 with this patch, you can test it like this:

Create a file /tmp/gtkrc with the following line:

pixmap_path "/where/the/pixmaps/are/pidgin"

Then start pidgin like this:

GTK2_RC_FILES=/tmp/gtkrc ./pidgin

What needs to be done:

• Fix all other occurences in an appropriate way, maybe combine them into a single

function.

• Add DATADIR/pidgin to the pixmap_path on runtime, so that pidgin looks first

into DATADIR/pidgin.

Kinds regards

Thomas Reifferscheid aka reiffert on freenode.

Please assign to Will Thompson

[resiak]

The ​freedesktop.org icon theme spec states:

By default, apps should look in $HOME/.icons (for backwards compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order).

I suggest we should add looking in $XDG_DATA_HOME/icons to that list (which usually means $HOME/.local/share/icons) and stick looking in DATADIR at the end, as is currently the case. So, the course of action probably looks something like:

• Move all the pixmap-lookup code into a single function.
• Add logic to search through the above sets of paths in order, using g_get_user_data_dir () and g_get_system_data_dirs ().
• #ifdef as necessary to make it compile on old Gtks.

I think this is probably better than obeying the gtkrc pixmap_path, which predates the freedesktop.org icon spec, since this brings us closer towards using proper icon themes.

[John Bailey]

reiffert: Have you addressed the issues resiak mentioned?

[John Bailey]

I have seen messages on IRC from reiffert saying that he no longer uses Pidgin and is no longer able to log in. From the former, I take that he no longer wishes to work on this patch; from the latter I take that even if he wanted to, he can't as he's not able to retrieve his password.

I might toss this into a side branch for further poking.

[sadrul]

I am looking at this one.

[sadrul@…]

(In ​a9579fef71ff6820f390a986132d30b079f590a0):
Try to be more compliant with the freedesktop.org icon spec thingy with the stock icons, by looking in user and system data-directories for the images before looking in DATADIR. Thanks to Thomas Reifferscheid aka reiffert for the initial patch. Closes #4988.