Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#5231 closed patch (fixed)

Big Custom smileys annoying in gtkconv

Reported by: salinasv Owned by: sadrul
Milestone: Component: pidgin (gtk)
Version: 2.4.0 Keywords:
Cc:

Description

Big custom smileys are just annoying because it takes all my gtkconv window to show.

This can be avoided with a GdkPixbufLoader?-fu

Attachments (2)

incoming.patch (1.8 KB) - added by salinasv 11 years ago.
Fix the incoming custom emoticon size
customSmileySizePref.patch (3.1 KB) - added by Xinef 8 years ago.
Adds Conversations prefs for resizing or not incoming custom smileys and to which size

Download all attachments as: .zip

Change History (16)

Changed 11 years ago by salinasv

Fix the incoming custom emoticon size

comment:1 Changed 11 years ago by sadrul

  • Component changed from unclassified to pidgin (gtk)
  • Owner changed from lschiere to sadrul

comment:2 Changed 11 years ago by sadrul@…

  • Resolution set to fixed
  • Status changed from new to closed

(In 6e7c4dd26da75349ba06490409bce8a1ccfbcb2a):
Patch from Masca to restrict the size of incoming custom smileys to a maximum of 96 pixels on either side. Closes #5231.

comment:3 follow-up: Changed 11 years ago by sadrul

I changed the max size to 96 (is it worth the effort to make it a theme setting?), and changed the resize code to make sure the wide smileys also aren't wider than the max size.

comment:4 Changed 11 years ago by Robby

This goes into 2.4.2?

comment:5 Changed 11 years ago by sadrul

No. Large parts of the custom smileys have been changed for the new Smiley API, which will be available in 2.5.0 (planned to be released after 2.4.2). This patch will also be available with that version.

comment:6 Changed 11 years ago by Robby

Oh, I see. Wouldn't it make sense then to assign it to a milestone named "2.5.0"?

comment:7 in reply to: ↑ 3 Changed 11 years ago by salinasv

Replying to sadrul:

I changed the max size to 96 (is it worth the effort to make it a theme setting?), and changed the resize code to make sure the wide smileys also aren't wider than the max size.

I don't see any problem with making a pref for this. Sounds like a good idea.

comment:8 Changed 8 years ago by Xinef

Sorry for digging up an old topic, but this is probably better than creating a ticket. I was actually looking for a way to disable this feature, as I want to see custom smilies I receive full size (or at least bigger than 96px). Was the pref for this ever implemented?

comment:9 Changed 8 years ago by deryni

Not that I can see anywhere.

Changed 8 years ago by Xinef

Adds Conversations prefs for resizing or not incoming custom smileys and to which size

comment:10 follow-up: Changed 8 years ago by Xinef

Attached a patch that adds the corresponding preferences.

comment:11 in reply to: ↑ 10 Changed 8 years ago by salinasv

Replying to Xinef:

Attached a patch that adds the corresponding preferences.

Applied, Please give us your name to give you credit.

comment:12 Changed 8 years ago by masca@…

(In 68ec69a92f608fa91e453499f83908b79b96d047):
Make the max size of incoming smileys a pref instead of harcoding it. Patch from Xinef (with small modifications) Refs #5231

comment:13 Changed 8 years ago by Xinef

Thanks for taking the time to integrate it properly (now that I see the 'modified' version, I can see my patch could have used some testing...) Quentin Brandon

comment:14 Changed 8 years ago by salinasv

Done, Thank you.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!