Opened 11 years ago

Closed 8 years ago

Last modified 8 years ago

#5303 closed defect (fixed)

two "block" menu items on gadu-gadu contacts

Reported by: liviopl Owned by: bartosz
Milestone: 2.10.0 Component: Gadu-Gadu
Version: 2.4.0 Keywords:
Cc: kkszysiu


it seems that pidgin supports gadu-gadu blocking ability and also his own, which doesn't notify the contact (ignores his messages).

this is confusing. pidgin's included blocking functionality should be unavailable for gadu-gadu contacts.

Attachments (1)

double-blocking.png (277.9 KB) - added by liviopl 11 years ago.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by liviopl


comment:1 Changed 11 years ago by deryni

I don't think I understand the difference between the two block methods, can you explain the difference? Does Gadu Gadu provide two different types of blocking or just one? If it only provides one then the gg plugin shouldn't provide its own block menu item and should just use the normal privacy system in pidgin.

comment:2 Changed 11 years ago by deryni

  • pending changed from 0 to 1

comment:3 Changed 11 years ago by liviopl

  • pending changed from 1 to 0

Protocol provides blocking method, and Pidgin provides own.

If it only provides one then the gg plugin shouldn't provide its own block menu item and should just use the normal privacy system in pidgin.

No, it shouldn't use Pidgin's method.

Protocol notifies blocked contact that it is blocked, while Pidgin's method only ignores the messages.

Pidgin's method shouldn't be available for Gadu-Gadu contacts.

comment:4 Changed 11 years ago by deryni

pidgin only provides internal privacy support when the protocol doesn't implement its own (a design decision I fought when it was made, I don't think pidgin should do that) the reason the pidgin method is available for gg is because the gg plugin doesn't tell libpurple that it supports blocking buddies, if it did that then pidgin would use that method and not the internal one. So this is a gg bug and as such I am assigning it to Bartosz.

comment:5 Changed 10 years ago by bernmeister

Is this still happening in Pidgin 2.5.8?

comment:6 Changed 10 years ago by deryni

Yes, this should still be the case in 2.5.8 and I still believe it to be an issue with the gg prpl. There is actually a comment in the gg code indicating that the code which provides the GG specific block/unblock menu items will need to go at some point. It doesn't look like making the change would be all that difficult, but I don't know enough about the features that the GG protocol provides to know what exact changes need to be made. Also, given the privacy rewrite SoC project I'm not sure how much this wants attention at the moment.

It would be handy if someone who uses the official GG client and/or knows the GG protocol could explain the full feature set of GG blocking though.

comment:7 Changed 9 years ago by rekkanoryo

  • Cc kkszysiu added

kkszysiu, any chance you might be interested in taking this on?

comment:8 Changed 9 years ago by deryni

Like I said originally, it looked to me like this should be a trivial change to make to the code. I just don't know GG at all so wasn't comfortable doing it myself. The main question is how to map the GG block stuff to the current privacy api (and whether there is privacy status stuff that needs handling, that is the "allow all", "allow below", etc. choices pidgin shows). Assuming the simple case I would think it should be enough to simply add them to the deny list, which would require exposing ggp_menu_block (modified appropriately) as the add_deny and rem_deny PrplInfo? callbacks.

comment:9 Changed 8 years ago by tomkiewicz@…

  • Milestone set to 2.8.1
  • Resolution set to fixed
  • Status changed from new to closed

(In d225b7ae359aa9448f679e2386a1f75326487b2e):
Merged two buddy blocking methods in Gadu-Gadu protocol. Fixes #5303

comment:10 Changed 8 years ago by tomkiewicz

  • Milestone changed from 2.8.1 to 2.9.1

comment:11 Changed 8 years ago by kkszysiu

I see that you're the one of Pidgin developers. Congratz! :)

comment:12 Changed 8 years ago by tomkiewicz

Just CPW with commit and trac permissions ;).

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!