Opened 11 years ago

Last modified 10 years ago

#5349 new patch

Pidgin should reserve a line for typing notifications

Reported by: shreevatsa Owned by:
Milestone: Patches Needing Improvement Component: pidgin (gtk)
Version: 2.4.0 Keywords: typing notification
Cc:

Description

The typing notifications make the conversation window scroll, which is distracting. This can be solved by reserving a line by default. I do not think there is any actual opposition to this change; it's just that no one is making it.

Here's a two-line patch that changes that, since it was already provided in the code.

Attachments (1)

reserveline.diff (977 bytes) - added by shreevatsa 11 years ago.
Change an ifdef

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by shreevatsa

Change an ifdef

comment:1 Changed 11 years ago by shreevatsa

Oh, I hadn't found #5062 when searching earlier.

This would fix #5062 if committed.

comment:2 Changed 11 years ago by grim

I for one am highly against reserving a line. The proper fix should be something like a signal getting emitted before the typing notification is displayed so that it can be stopped from a plugin. Once I find some time, I am planning on implementing this unless someone beats me to it.

comment:3 Changed 11 years ago by deryni

I think reserving a line is likely a good thing, but I don't think we should do it at the cost of preventing it from being disabled in the manner grim is talking about (or in other manners) nor do I really think the method in the patch (in the code really) is the correct way to do this sort of thing. I have been under the impression that it should be possible with a plugin to change the display characteristics of the typing-notification text tag and thus hide the typing notification text, is this not correct?

comment:4 Changed 11 years ago by andrixnet

Two more details :

  • tab color in 2.4.1 does not change to indicate "typing notification"
  • if I send a message while the other is typing, the typing notification is replaced by my message

comment:5 Changed 11 years ago by andrixnet

on tab color I mean "active tab". I make a point of it, because of the second detail

comment:6 Changed 11 years ago by deryni

The tab title doesn't change colors or the infopane text doesn't change color? The tab title should, the infopane title should not, given the current code. I make no claims about whether the infopane text should or should not change. And you mean that the typing notification is entirely replaced, that is entirely gone if you send a message while your buddy is typing?

comment:7 Changed 11 years ago by Voyagerfan5761

Regarding the disappearing notification andrixnet mentioned, I haven't experienced that on my own setup (WinXP). Maybe that should be its own ticket.

comment:8 Changed 11 years ago by rekkanoryo

  • Milestone set to Patches Needing Improvement

It's clear from the comments here that this patch should be revised.

comment:9 Changed 10 years ago by deryni

Do we still need this now that gtkrc settings can disable (and modify) the inline typing notification?

comment:10 Changed 10 years ago by sadrul

  • Status changed from new to pending

comment:11 Changed 10 years ago by shreevatsa

  • Status changed from pending to new

Oh, what is the gtkrc setting to disable/modify the notifications?

The reason for reserving a line is so that typing notifications are still displayed, but 'buddy starts typing' does not make the history scroll up. If the gtkrc settings can do this, then this is no longer needed.

comment:12 Changed 10 years ago by deryni

  • Status changed from new to pending

The gtkrc settings cannot reserve a line, they can only disable the new notifications and modify the styling of the new notifications. My question was whether there was a feeling that we should support reserving a line or whether simply allowing people to disable/style it was enough.

comment:13 Changed 10 years ago by shreevatsa

  • Status changed from pending to new

If I remember correctly, most of the opposition to the typing notifications was that they caused the history window to unexpectedly scroll up as if a new message had arrived. The notifications are useful, and the 'right' way to do them is to have them in a separate reserved area, as done by Adium, iChat, Gmail etc.

But of course ultimately it's subjective and just individual preference, and I'm personally fine with anything.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!