Opened 11 years ago

Closed 11 years ago

#5639 closed patch (fixed)

openq 02 patch - fixed multiarch

Reported by: csyfek Owned by: csyfek
Milestone: 2.4.3 Component: QQ
Version: 2.4.0 Keywords: QQ multiarch patch
Cc:

Description

2008.04.25 - ccpaging <ecc_hy(at)hotmail.com>, csyfek <csyfek(at)gmail.com>

  • Rewrite read_packet and create_packet functions, use qq_put and qq_get functions instead
  • New logic in accord with protocol models to handle packets, some related functions rewritten

successfully compiled and login on ibook G4, which runs with a PowerPC G4.

Cheers,

SHiNE

Attachments (2)

02-fix-multiarch-20080426.patch.gz (42.7 KB) - added by csyfek 11 years ago.
to use this patch, you *MUST* apply the 01-rm-qq_crypt patch first.
purple-qq-02-multiarch.diff (246.8 KB) - added by QuLogic 11 years ago.

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by csyfek

to use this patch, you *MUST* apply the 01-rm-qq_crypt patch first.

comment:1 Changed 11 years ago by Sim-on

  • Type changed from defect to patch

comment:2 Changed 11 years ago by QuLogic

Here's a copy of the patch that's not gzipped.

I cleaned it up a little, by removing some excess whitespace changes, and by converting /* commented code */ to #if 0 commented code #endif. I made sure it compiled, and fixed up the warnings (those were important! there were definite problems that needed fixing).

I also changed the purple_debug calls in packet_parse.c to be INFO instead of ERROR, because they certainly are not errors, and I found it annoying with all that unnecessary red text in my debug window.

The only place I took some extra liberties is with packet_parse.c, where I removed the commented code, because it was clear that replacement functions were written and already in use everywhere. There's no use in leaving the old code around; if you were to need the old code, that's what MTN is for.

Since I've never been able to login to QQ, someone else will have to check whether those fixes were correct.

Changed 11 years ago by QuLogic

comment:3 Changed 11 years ago by csyfek

This patch is outdated. Many problems have been solved in the later patches. Please take a look at the 03, 04 and 05 patches.

comment:4 Changed 11 years ago by QuLogic

Yes, I'll get to them soon. But 03, 04, and 05 all depend on 02, right?

comment:5 Changed 11 years ago by csyfek

yes~

comment:6 Changed 11 years ago by QuLogic

  • Owner changed from seanegan to csyfek

This is yours now.

comment:7 Changed 11 years ago by csyfek

  • Keywords QQ added
  • Milestone set to 2.4.3
  • Resolution set to fixed
  • Status changed from new to closed

Thanks! :P

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!