Opened 11 years ago

Last modified 2 years ago

#6265 new defect

Kick users with blank as a nickname in a conference

Reported by: ManHol Owned by: darkrain42
Milestone: Patches Needing Review Component: XMPP
Version: 2.10.9 Keywords: kick blank nickname
Cc: jmturner, makeshift

Description

I can't kick users who are changing their nicks to blank by typing /nick<blank><blank>. I tried the /kick command. Unfortunately the commands /kick<blank><blank> or /kick<blank>"<blank>" wasn't successful.

Attachments (3)

commands.patch (1.2 KB) - added by wyuka 8 years ago.
I think this patch fixes #6265 and #6027
jabber.patch (827 bytes) - added by brandon.bell 5 years ago.
Remove reason for /role, change /kick function
chat.patch (2.8 KB) - added by brandon.bell 5 years ago.
Add kick function

Download all attachments as: .zip

Change History (20)

comment:1 Changed 11 years ago by chemistrydioxide

Does /kick support additional parameters?

If not, everything that is after "/kick " should be considered part of the nickname; spaces other than the one that seperates the nick from the /kick command should not be treated as a parameter seperator.

comment:2 Changed 11 years ago by chemistrydioxide

I just realized that it might be difficult to implement this if the implementation of / commands doesn't allow command-specific space handling.

I think kicking people using a context menu option would be very very very useful.

comment:3 Changed 11 years ago by ManHol

I totally agree with that. Is there a problem by adding a context menu option only in case you have moderator/owner rights? If it's not I would love to have /affiliate, /configure, /role and /ban context menu options, too. Its quite difficult to find the commands without knowing there are some. (As far as I know, every Jabber Client handles this moderator/owner functions different and they haven't got a command like /configure or /affiliate implemented)

comment:4 follow-up: Changed 11 years ago by chemistrydioxide

This is a duplicate of #264

comment:5 in reply to: ↑ 4 Changed 11 years ago by rekkanoryo

Replying to chemistrydioxide:

This is a duplicate of #264

This is NOT a duplicate of #264. This ticket is a bug report stating that /kick on XMPP does not handle nicks with spaces. That's a far cry from more options in the user list's right-click menu.

comment:6 Changed 11 years ago by deryni

Historically the problem with adding right-click menu options to the chat room user list was that the user list didn't contain enough information to allow the menu actions to be performed correctly. That may or may not have been fixed since the last time I looked, if it has then adding the menu items should not be difficult, if it hasn't then that will need to be fixed first.

comment:7 Changed 10 years ago by magnus.therning

As a temporary workaround it is possible to kick people out using the XMPP Console, at least in XMPP-based chat rooms:

<iq type='set' id='purplefa881723' to='rooom@server.com'>
	<query xmlns='http://jabber.org/protocol/muc#admin'>
		<item jid='foo@bar/Location' role='none'/>
	</query>
</iq>

comment:8 Changed 10 years ago by bernmeister

Does this temporary workaround constitute the makings of a patch? If not, maybe move this to Patches Welcome?

comment:9 Changed 10 years ago by darkrain42

  • Milestone set to Patches welcome
  • Owner changed from nwalp to darkrain42

comment:10 Changed 10 years ago by deryni

For the record, "recent" changes to the XMPP MUC spec have made it clear that MUC services MUST NOT allow users to set all blank nicknames, which mitigates the specific nickname mentioned here (but not nicknames that merely contain spaces). I'm unsure, as I haven't looked at our command parsing code in ages, whether it is possible to have quoted arguments or whether it would be possibly to support quoted or escaped spaces.

comment:11 Changed 9 years ago by darkrain42

Ticket #12132 has been marked as a duplicate of this ticket.

comment:12 Changed 9 years ago by darkrain42

Related: #6027

Changed 8 years ago by wyuka

I think this patch fixes #6265 and #6027

comment:13 Changed 8 years ago by darkrain42

  • Milestone changed from Patches welcome to Patches Needing Review

comment:14 Changed 8 years ago by darkrain42

  • Milestone changed from Patches Needing Review to Patches Needing Improvement

Ugh, apparently FF timed out when I tried to update this. Per conversation in #pidgin, this current patch doesn't handle the case where the in-room nick is something like dark"rain (i.e. with a raw double-quote in the middle).

Changed 5 years ago by brandon.bell

Remove reason for /role, change /kick function

Changed 5 years ago by brandon.bell

Add kick function

comment:15 Changed 5 years ago by brandon.bell

The two patches attached allow you to kick a user based on either their nickname (no spaces), or their full JID. The reason (/kick <user> <reason>) also works as before it was ignored.

comment:16 Changed 5 years ago by datallah

  • Milestone changed from Patches Needing Improvement to Patches Needing Review
  • Version changed from 2.4.3 to 2.10.9

comment:17 Changed 2 years ago by makeshift

Has there been any update on the main branch for this ticket? It is still an issue when using XMPP day to day.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!