Opened 10 years ago

Last modified 10 years ago

#6987 new patch

Padding around chat window is unnecessary

Reported by: moreati Owned by: deryni
Milestone: Patches Needing Review Component: pidgin (gtk)
Version: 2.5.1 Keywords:
Cc: IceWil, elreydetodo, pocek

Description (last modified by moreati)

The Pidgin chat window has a 6 pixel padding surrounding it. Comments in pidgin.h state this is due to the Gnome HIG.

The HIG <http://library.gnome.org/devel/hig-book/stable/design-window.html.en> refers to a dialog box when suggesting a 12 pixel border.

I believe having this border is:

  • Not necessary, the chat window is closer to being a document window than a dialog.
  • Wasteful of space, especially when the chat window is made thin.

Attachments (4)

pidgin-chat-border.patch (1.6 KB) - added by moreati 10 years ago.
Remove border from chat window
Screenshot-#pidgin.png (58.1 KB) - added by moreati 10 years ago.
Screenshot showing border removed
no-padding.patch (3.8 KB) - added by IceWil 10 years ago.
My patch for padding
Capture.png (82.4 KB) - added by IceWil 10 years ago.
Screenshot with no border and my theme

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by moreati

Remove border from chat window

Changed 10 years ago by moreati

Screenshot showing border removed

comment:1 Changed 10 years ago by moreati

This patch does not address address what I see as another issue. The chat history scroll bar is not flush with the window edge, if in a multi person chat room, due to the presence of the resizing handle of the person list.

Padding between the tabs and the topic label may need to be restored.

comment:2 Changed 10 years ago by bernmeister

I guess either move this to Patches Needing Review or close as a won't fix.

comment:3 Changed 10 years ago by darkrain42

  • Milestone set to Patches Needing Review
  • Owner set to deryni
  • Type changed from enhancement to patch

The image (since trac has the HTML entity escaping bug).

I think that screenshot looks pretty busy, but it doesn't nearly look that bad with my theme here.

comment:4 Changed 10 years ago by deryni

  • Status changed from new to pending

Which padding exactly is this getting rid of?

comment:5 Changed 10 years ago by moreati

  • Description modified (diff)
  • Status changed from pending to new

comment:6 Changed 10 years ago by deryni

That after screenshot has horrible border clipping and other issues.

The infopane text looks unevenly placed between the top of the window and the history area, the border between the history area and the frame background is no longer clean but rather a stark color change at an (apparently) arbitrary point, the scrollbar arrows try but don't quite line up flush with the external border of the history area leaving a 'smudge' line, and possibly worst of all the input area swallows essentially all border indication and looks like it overflowed the space it was supposed to be given.

I'm not sure how many of those changes are attributable to the patch versus your other theme changes but on the whole I think the after shot looks immensely worse than the before shot and does so for no real gain that I can see. The only benefit I can see is that under certain specific circumstances it becomes easier to target the scrollbar with the mouse. Those circumstances being when the window sits flush with the right edge of the desktop, and the GTK+ tab, and window manager window borders have zero size (a scenario I doubt ever really happens). In all other cases moving the scrollbar to the side of the window is of no real help. Oh, let us not forget that the scroll wheel works in the entire history area as a way to scroll so targetting the scrollbar is not even really all that necessary (not to mention that if you click in the history area the arrow keys and page up/page down keys navigate the history area as well).

Do you see some other benefit(s) to this change? Even with an incredibly tiny font size of six pixels removing this padding would only buy you two characters per line, that is an awfully small return for this change.

I will build a copy of pidgin with the padding change and see what the resulting window looks like, but I'm not convinced it will be better enough in any real way to warrant the change.

Changed 10 years ago by IceWil

My patch for padding

comment:7 Changed 10 years ago by IceWil

Sorry if I do that wrong, it's my first patch. (and sorry for my english I'm french)

Changed 10 years ago by IceWil

Screenshot with no border and my theme

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!