Opened 10 years ago

Last modified 9 years ago

#7140 new patch

Use the Pidgin emoticon theme instead the protocol's set

Reported by: jpaul Owned by: salinasv
Milestone: Patches Needing Improvement Component: custom emoticons
Version: 2.5.1 Keywords: emoticons custom msn
Cc: marsjaninzmarsa

Description

Hi,

There is an option of the MSN protocol that I dislike (i'm more Jabber fanboy): custom emoticons. Lot of people use them to send me plenty of images for nothing.

As Pidgin allow to set custom emoticons, it would be interesting to set the selected Pidgin emoticon able to be sended instead of just characters.

I will try to explain that (excuse my english). If i write ":)", ":)" is sended via the IM protocol On the other side, the client that receives the ":)" will output it as an emoticon. What would be intersting is to send the smiley of the pack i setted in the pidgin settings: If I write: ":)" and ":)" exists in my emoticon theme, so ":)" WITH the picture is sended to the other client.

In short: I want my contacts to see my pidgin's emoticons.

Thanks

Attachments (1)

7140_09_05_05.patch (4.3 KB) - added by salinasv 10 years ago.
Preliminary patch

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by deryni

Just so this is clear, you want to automatically use the selected pidgin smiley theme as a set of custom smileys for protocols that support custom smileys?

comment:2 Changed 10 years ago by jpaul

Exactly :)

comment:3 Changed 10 years ago by lschiere

  • Owner lschiere deleted

comment:4 Changed 10 years ago by salinasv

  • Owner set to salinasv

I don't think this will be hard to do. I'm not sure is how we must enable/disable this behavior, maybe a checkbox on the themes tab on pref dialog?

comment:5 Changed 10 years ago by salinasv

  • Component changed from unclassified to custom emoticons
  • Milestone set to 2.6.0

I have been browsing the code and found that we can check for this preference at theme load time and add each GtkIMHtmlSmiley to the PidginSmiley? list.

We need a new pidgin_smiley_add_to_list_from_gtkimhtml() function and use it in gtkthemes.c:323

If there is no objection to this approach I will hack it this way the next week. Now I need to sleep.

Changed 10 years ago by salinasv

Preliminary patch

comment:6 follow-up: Changed 10 years ago by salinasv

  • Milestone changed from 2.6.0 to Patches Needing Review

I have uploaded a patch that do the magic. Now we need to show it nice in the IMHTMLToolbar and try to not load the file more than once.

I want to ask developers if you think we must add a preference for this or just do it as default?

I guess we will need to add some api to gtkthemes to be able to know if some shortcut is defined by the theme.

comment:7 Changed 10 years ago by salinasv

Ticket #8067 has been marked as a duplicate of this ticket.

comment:8 Changed 10 years ago by salinasv

  • Type changed from enhancement to patch

comment:9 in reply to: ↑ 6 Changed 10 years ago by QuLogic

  • Milestone changed from Patches Needing Review to Patches Needing Improvement

Replying to salinasv:

I have uploaded a patch that do the magic. Now we need to show it nice in the IMHTMLToolbar and try to not load the file more than once.

Based on this, is this is ready yet?

I see a few problems.

  1. Inserting a smiley with an apostrophe comes out as '
  2. In the smiley manager, all the custom ones are blurry (probably the case for all smileys at lower res, but it's more evident this way).
  3. On MSN, all the normal smileys went disabled. In the Debug Window, it said:
    (01:00:02) smiley: :) custom: 0 with flags 800
    (01:00:02) Gtk: gtk_box_pack: assertion `child->parent == NULL' failed
    

comment:10 Changed 10 years ago by salinasv

Nop, it's not ready yet, it was just an 'update' on the ticket to show how this can be made and to get some feedback about the preference bit.

I have just finished my exams. I will try to hack the problems you point and try to make this to look better.

comment:11 Changed 10 years ago by QuLogic

It looks like point 1 is the same problem as #6883.

comment:12 Changed 9 years ago by malu@…

(In 7fb07587f5c87cbf108267d40521da8e2ec4d6fd):
Only scale down larger smileys (more than 22 px width or height) in the smiley manager. This avoids getting smaller smileys being blurry. Refs #7140

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!