Opened 8 years ago

Last modified 8 years ago

#7523 new enhancement

Enable/disable smiley function

Reported by: ccpaging Owned by:
Milestone: Component: pidgin (gtk)
Version: 2.5.2 Keywords:
Cc: csyfek, khc, moo, Lehych

Description (last modified by ccpaging)

As programer, we always like to talk on IM, and send some program source or file path in IM text. The smiley convert make those IM hard to read. Selecting emoticon theme to "none" avoids smiley converting, but it is not enough.

Is it possible to implement "Enable / disable smiley" menu item in input widget's right click menu or format menu? If smiley is disabled, the protocol will get IM text include: <font sml="none"> ... </font>

I am sure qq plugin can handle sml="none.

How about other protocols?

Change History (5)

comment:1 Changed 8 years ago by ccpaging

  • Description modified (diff)

comment:2 Changed 8 years ago by datallah

  • Component changed from winpidgin (gtk) to pidgin (gtk)
  • Owner datallah deleted

comment:3 Changed 8 years ago by khc

we talked couple days ago, the issue is that for QQ, the prpl has to explicitly mark the smileys with special bits, so it's possible to differentiate between smiley and text. Other protocols can't do that, as far as I know.

The right click menu already has a disable smiley button, but that's locally only. If we wrap the text with sml="none" when the prpl supports formatting, that will give prpl-qq an opportunity to do the right thing.

I took a quick look and it shouldn't be too hard to do. I just kept getting distracted...

comment:4 Changed 8 years ago by moo

hi ccpaging, i checked qq/im.c and see that it strip all html code and then do the scan. it simply check <font sml="none"> before it strip. well, this can be the easiest wast to implement it. but don't you think it better if you scan through the html tree, look for elements and text nodes? links like <a href="..."> should not be scanned for smilie code. also, with this scanning manner, <font sml="none">/smilie</font>/smilie can be mixed together in the same message.

comment:5 Changed 8 years ago by ccpaging

Scan html tree should be better way.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!