Opened 11 years ago

Last modified 10 years ago

#7550 new patch

improve colors in plugin selection dialog

Reported by: caseyho Owned by: deryni
Milestone: Patches Needing Improvement Component: pidgin (gtk)
Version: 2.5.2 Keywords: plugin menu
Cc: pidgin@…

Description

When you open the plugins menu, it's hard to tell what plugins you have enabled. You need to scroll down the list and scan for the tiny checkboxes.

This patch attempts to make the enabled plugins more obvious and easier to differentiate. It's a simple change- instead of coloring odd/even rows differently, now the enabled/disabled plugins are colored differently.

Attachments (5)

pluginsmenu.diff.gz (931 bytes) - added by caseyho 11 years ago.
before-windows.jpg (53.3 KB) - added by caseyho 11 years ago.
after-gnome.jpg (59.1 KB) - added by caseyho 11 years ago.
before-gnome.jpg (60.8 KB) - added by caseyho 11 years ago.
work_plugins.png (15.2 KB) - added by deryni 11 years ago.
The plugins dialog I see at work.

Download all attachments as: .zip

Change History (18)

Changed 11 years ago by caseyho

comment:1 Changed 11 years ago by deryni

Please stop zipping simple diff files. It makes it rather more annoying to glance at them quickly to comment on them.

You are aware that you can sort plugins by the Enabled column by clicking on it, correct? Given that (and the fact that you can change the size of the checkboxes if your theme draws the checkboxes smaller than you would like) I'm not sure I think this is needed (though I have nothing against it as such).

comment:2 Changed 11 years ago by charding

Or maybe the diff could just have the plugins sorted by Enabled by default when it opens.

comment:3 Changed 11 years ago by caseyho

The sorting wasn't immediately obvious to me (until I actually stared at the dialog for longer than 10 minutes). It's good that it's there, but we shouldn't rely on it.

Sorting by enabled might be good too- one corner case though- if a user is enabling/disabling plugins the newly updated plugins will be funny. Either we immediately move it to the correct sort position (and the user needs to scroll to undo the change if it was an accident) or we don't sort it and it's equally hard to see.

comment:4 Changed 11 years ago by deryni

I think alphabetic sorting is a better default, it makes it more stable and predictable and is probably what more people would expect.

Can you upload a screenshot of your plugin dialog? I'm curious what exactly you are seeing.

Changed 11 years ago by caseyho

Changed 11 years ago by caseyho

Changed 11 years ago by caseyho

comment:5 Changed 11 years ago by caseyho

screenshots attached. note that gnome-ubuntu has alternate shading, whereas the windows theme has no shading at all.

i don't have an "after patch" build on my windows machine, but it should be similar to to the gnome screenshot.

comment:6 Changed 11 years ago by deryni

I find all of those screenshots unpleasant to varying degrees.

I find the Windows one unpleasant because of the lack of row rules and because of the incredibly high degree of contrast.

I find the Gnome before one unpleasant because the row rule color is just off enough (here on my screen) to make me think my eyes are having problems as opposed to there being ruled lines.

And lastly I find the Gnome after one unpleasant because the chosen color seems to come out of nowhere (and in fact does come out of nowhere in your patch, and thus will fail for dark themes) and as I commented strikes me as just redundant, I can't help but see the color and checkbox always being in sync as annoying.

If you really want something like this I would suggest that perhaps dimming the text for disabled plugins might be a better idea (as it would be more obvious than the current situation, more appropriate as it de-emphasizes the items that are not of current interest, and is what Firefox at least seems to do).

As a final comment, whether or not rule rows are drawn is entirely up to the GTK+ theme, Windows as a rule does not have them so the Windows GTK+ theme does not draw them (other themes on Windows do, as the screenshot I'm going to attach in a moment will show).

Changed 11 years ago by deryni

The plugins dialog I see at work.

comment:7 Changed 11 years ago by rekkanoryo

Why not just have a checkbox at the top of the plugins dialog (defaulting to unchecked) with the text "Hide plugins not being used" or similar, that when checked will hide all disabled plugins? I'm not at all convinced screwing with row coloring is a good idea.

comment:8 Changed 11 years ago by rekkanoryo

Or better yet, now that I think about it, a group of radio buttons like so:

  Show plugins: ( ) All   ( ) Disabled Only   ( ) Enabled Only

and default to All.

comment:9 Changed 11 years ago by deryni

I think we need to ask what we are trying to make easier before we can really come up with a good way to fix it. So caseyho, what exactly are you doing in the Plugins dialog when you have the problem you filed this ticket about?

At the moment I think having radio buttons of that sort seems entirely unhelpful in any meaningful way.

comment:10 Changed 10 years ago by darkrain42

  • Milestone set to Patches Needing Improvement
  • Owner set to caseyho

comment:11 Changed 10 years ago by deryni

As a related note, it has been mentioned more than once in #pidgin that we really should have a way to let people see prpl:s in the Plugins dialog as not seeing them there has confused more than one person. So perhaps it would make sense to have a dropdown with "Show Enabled Plugins", "Show Plugins", and "Show Hidden Plugins" (wording definitely needs improvement) entries. I can't quite see the use in seeing only Disabled plugins, though perhaps we might also want a "Show Broken Plugins" entry.

caseyho: I still want to know what you were doing with the plugins dialog that prompted this request in the first place.

comment:12 Changed 10 years ago by darkrain42

As a related note (I meant to look at the GTK widgets but forgot), I recently was irked that clicking on the Enabled column at the top sorted Disabled above Enabled with a single click. I would prefer that this sort the enabled plugins to the top with a single click.

comment:13 Changed 10 years ago by deryni

  • Owner changed from caseyho to deryni
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!