Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8045 closed patch (fixed)

support for XEP-0191 simple blocking server update

Reported by: darkrain42 Owned by: deryni
Milestone: 2.6.0 Component: XMPP
Version: Keywords: privacy block blocking
Cc: lukatmyshu

Description

#7670 introduced support for XMPP XEP-0191 Simple Blocking.

This patch adds support for the server pushing updates to the client when another resource modifies the block list.

As I noted on that ticket, this is entirely untested on my part (I think I tested that it compiles)

Attachments (2)

simple-blocking-push.patch (3.2 KB) - added by darkrain42 10 years ago.
simple-blocking-push-update.patch (4.3 KB) - added by darkrain42 10 years ago.
Updated patch

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by darkrain42

comment:1 Changed 10 years ago by MarkDoliner

  • Cc lukatmyshu added

comment:2 Changed 10 years ago by darkrain42

  • Keywords privacy block blocking added
  • Summary changed from support for XEP-0191 simple blocking support servers update to support for XEP-0191 simple blocking server update

Mark, I'd love to test my patch; do you know of any servers that implement XEP-0191?

side note: the logic in lines 1465 and 1466 is wrong. It should be if (!(child = xmlnode_...) && !(child = xmlnode_...)) ("if the child isn't <block/> and the child isn't <unblock/>").

comment:3 Changed 10 years ago by MarkDoliner

jabberd2 supports XEP-0191. I don't know how bug-free the implementation is. http://jabberd2.xiaoka.com/

comment:4 Changed 10 years ago by rekkanoryo

  • Milestone set to Patches Needing Review

comment:5 Changed 10 years ago by QuLogic

  • Keywords changed from privacy, block, blocking to privacy block blocking
  • Status changed from new to pending

I think this patch needs to be re-spun to match the changes to the IQ handlers. Also, did you get a chance to test this on a server?

And keywords are space-separated.

comment:6 Changed 10 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to Patches Needing Improvement

If the patch needs respun, this ticket doesn't belong on the "Patches Needing Review" milestone.

Changed 10 years ago by darkrain42

Updated patch

comment:7 Changed 10 years ago by darkrain42

  • Status changed from pending to new

Attachment (simple-blocking-push-update.patch) added by ticket reporter.

comment:9 Changed 10 years ago by darkrain42

ugh, I can't test this because jabberd2's support for pushing privacy updates doesn't appear to work. Updated patch anyway.

comment:10 Changed 10 years ago by darkrain42@…

  • Milestone changed from Patches Needing Improvement to 2.6.0
  • Resolution set to fixed
  • Status changed from new to closed

(In d5451d4ca60f9201d94adc9dc0cea60cd2f68eba):
Support pushed notifications about XEP-0191 Blocks/Unblocks?. Closes #8045.

Recompiling jabberd2 from scratch magically made the pushes work, so I was able to test this and it works, except for causing a crash in jabberd2 that Mark already fixed. :)

comment:11 Changed 10 years ago by MarkDoliner

Awesome!

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!