Opened 10 years ago

Closed 10 years ago

#8663 closed patch (fixed)

[PATCH] Make account editor fit smaller screens

Reported by: mterry Owned by:
Milestone: 2.6.0 Component: pidgin (gtk)
Version: 2.5.5 Keywords: size

Description (last modified by rekkanoryo)

This is a sister bug to bug #7548.

This patch will make the 'Add/Modify? Account' dialog fit the smaller form factor of today's netbooks (~1280x576).

The only problem protocol was SILC, whose many many options made the dialog too large vertically.

To work around this, I did the following:

  • Move proxy settings to their own tab (as discussed on mailing list)
  • Took away the header labels for Proxy and Protocol options, because they were the only sections on their tabs
  • Tweaked the borders of a couple boxes. Notably, I reduced the dialog's total border and the spacing between the content and dialog-button boxes. This involved a change from PIDGIN_HIG_BORDER to PIDGIN_HIG_BOX_SPACE. Now, this may seem like a break from HIG, but it actually makes the dialog respect the HIG. Before, I was getting ~20 pixel border, and the dialog buttons were swimming in space. It seems GTK+ insists on adding some of its own spacing around the place. By reducing the assigned border, it now is 12 pixels around the edge of the dialog, and about 20 around the dialog buttons. Those dialog buttons seem to insist on lots of space. This same fix might want to be applied elsewhere? The other dialogs in pidgin seem roomy to me. Do I just have some crazy theme that is doing this (Human on Ubuntu)?

Attachments (3)

account.diff (5.7 KB) - added by mterry 10 years ago.
advanced.png (26.8 KB) - added by mterry 10 years ago.
new advanced tab
proxy.png (19.8 KB) - added by mterry 10 years ago.
new proxy tab

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by mterry

comment:1 Changed 10 years ago by mterry

  • Type changed from enhancement to patch

Changed 10 years ago by mterry

new advanced tab

Changed 10 years ago by mterry

new proxy tab

comment:2 Changed 10 years ago by rekkanoryo

  • Description modified (diff)

Fixed some wiki formatting on the original submission.

comment:3 Changed 10 years ago by michael.terry@…

  • Milestone set to 2.6.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 59d56711bc1fccc226a6508d153bae1466437969):
Break the New Account dialog into three tabs. Move proxy options to the new tab. Fixes #8663.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!