Opened 10 years ago

Closed 10 years ago

#8691 closed patch (fixed)

Statusbox Icon - UI Enhancement

Reported by: kostaa Owned by:
Milestone: 2.6.0 Component: pidgin (gtk)
Version: 2.5.5 Keywords: statusbox buddy icon
Cc: karvanitis

Description

There are effectively two enhancements proposed in this patch. As such, they can be considered separately if desired. Obviously because such changes are subjective by nature but my hope is that they work to add an additional level of detail while keeping with the clean and simple design goals of this project.

First, the buddy icon image has had rounded corners applied to it in an attempt to keep with the uniform look of the other buddy icons located in the buddy list. Not a huge change by any stretch.

Second, the buddy icon image has been positioned to the left of the toggle button for all (not just RTL) text directions. I find this to be optimal as it helps differentiate the users buddy icon from those in the buddy list.

As a discussion point I am confused as to why RTL/LTR text directions would want their buddy icon placed in separate locations seeing as its not actual text. It would be another issue to have it localized to the language - but that's not the case.

This particular design choice could possibly be made by the user as a selection via the buddy icon context menu. However, I would personally prefer to see it as being statically placed as in the patch.

See attached screenshot.

Attachments (2)

gtkstatusbox.c.patch (2.4 KB) - added by kostaa 10 years ago.
statusbox ui enhancement patch
Screenshot-Buddy_List.png (16.5 KB) - added by kostaa 10 years ago.
statusbox enhancement screenshot

Download all attachments as: .zip

Change History (15)

Changed 10 years ago by kostaa

statusbox ui enhancement patch

Changed 10 years ago by kostaa

statusbox enhancement screenshot

comment:1 Changed 10 years ago by rekkanoryo

  • Milestone set to Patches Needing Review

comment:2 Changed 10 years ago by darkrain42

Can anyone shed some light on why the box moves depending on whether the text (of the locale? of the text in the statusbox?). It doesn't make much sense to me.

That said, I think the patch looks good.

comment:3 Changed 10 years ago by darkrain42

*the text is RTL or LTR.

comment:4 Changed 10 years ago by rlaager

The icon is being placed "after" the text. The direction of reading affects what is "after". I vote for accepting the rounding and dropping the other part (which moves the icon).

comment:5 Changed 10 years ago by karvanitis

To better understand I would like to see a use case that demonstrates the intended purpose of the current implementation and which proves its overall correctness.

The confusion, for me, arises by asking the following question: "Why does the reading direction of the status text dictate the positioning of the icon?"

Your concept that the icon is being placed "after" the text, is a fair one. However, the definition of what comes "after" what in a language should be defined by grammatical syntax not reading direction alone. To make such an assumption could lead to incorrect usage given the nature of some languages (I make no claims to know them all).

Therefore, to properly place the icon "after" the text would require inherit knowledge of the users actual language (ie: localized text). By statically placing the icon, however, we are decoupling the icon placement from the localization issue all together and making it a design choice.

comment:6 Changed 10 years ago by deryni

I'd argue that we should always place the buddy icon on the right, in line with all the other buddy icons (presumably we don't reverse those in RTL locales, do we?). Moving it along with the locale direction seems to me to be clearly incorrect, as is moving it to the left solely to differentiate it from the icons in the buddy list. It is already differentiated by being the last visible icon, by being in a differently colored box, by being next to the status selector, etc moving it out of line with the other icons makes it harder to locate (you have to remember it is on the other side), requires a change for all LTR users (presumably a larger portion of our users than RTL users are), and other than the added differentiation I see no utility from it.

(It may be worth keeping the statusbox in mind when thinking about the buddy list themes, it may make sense to have the statusbox mimic the current buddy list theme or it may make sense to define a static style for the statusbox and always use that. I'm unsure.)

I'm uncertain about the rounding idea but have no real objections to it, my only concern is that it may cause people to wonder if the icon they uploaded is similarly rounded and/or to complain that the icon they uploaded was changed by pidgin.

comment:7 Changed 10 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to 2.6.0

Accepting, rejecting, or requesting improvement of this patch is a blocker for the release of version 2.6.0.

comment:8 Changed 10 years ago by Paradox

I definitely appreciate the rounded corners on the user image as it gives better visual coherency with the rest of the buddy list.

As for whether the icon is left-aligned or right-aligned doesn't really make a difference. The left-aligned icon fits nicely with the status dropdown, while the right-aligned icon is against the dropdown menu's arrow.

comment:9 Changed 10 years ago by darkrain42

kostaa, what name should I put in the COPYRIGHT/ChangeLog for you?

comment:10 Changed 10 years ago by darkrain42@…

(In d4f448adc2a9753af706e001358285d3041fa091):
Leave the icon always on the right (regardless of language direction).

It looks like the buddy list icons don't move, so why should this?

References #8691.

comment:11 Changed 10 years ago by darkrain42@…

(In 3c0721c94e58fc83dff576f4577fd9ef59fce989):
Draw the user's buddy icon (in the status box) with curves, to match the buddy list icons.

I fixed the ref-counting to not leak. Refs #8691 (waiting for the name to put in COPYRIGHT).

comment:12 Changed 10 years ago by karvanitis

I should already be there "Kosta Arvanitis". Used the wrong account for submission of this patch.

comment:13 Changed 10 years ago by darkrain42@…

  • Resolution set to fixed
  • Status changed from new to closed

(In 3dda0f0368fa201996298aa3fcd6061bdffb58ad):
Update the ChangeLog appropriately.

Closes #8691.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!