Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8775 closed patch (fixed)

Add "Choose" menu item to avatar menu in statusbox

Reported by: nops Owned by:
Milestone: 2.6.0 Component: pidgin (gtk)
Version: 2.5.5 Keywords:
Cc:

Description

Then right clicks on avatar icon in statusbox, showed popup menu with one item - "Remove". I think, this menu must have item to choose icon (see attachment). This will be more intuitive to users.

Attachments (2)

ChooseItem.png (20.2 KB) - added by nops 10 years ago.
"Choose" menu item
choose.patch (2.1 KB) - added by nops 10 years ago.
Patch to add "Choose" item to avatar popup menu

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by nops

"Choose" menu item

Changed 10 years ago by nops

Patch to add "Choose" item to avatar popup menu

comment:1 Changed 10 years ago by datallah

I think this is probably reasonable from a intuitiveness standpoint(even though a normal click on the image performs the function).

comment:2 Changed 10 years ago by rekkanoryo

  • Milestone set to Patches Needing Review

comment:3 Changed 10 years ago by QuLogic

This looks OK to me, but do we want an icon for that Choose menu item?

comment:4 Changed 10 years ago by deryni

I don't know if we need an icon but we need a better word choice than "Choose" as that is entirely unhelpful. "Select Icon", "Select New Icon", "New Icon", or even "Choose Icon" (though I still think choose is the wrong verb choice) are all better, but further suggestions would be good.

comment:5 Changed 10 years ago by nops

I select "Choose" because it open icon chooser (pidgin_buddy_icon_chooser).

That about add a similar button to general tab in account preferences?

comment:6 Changed 10 years ago by deryni

I can almost guarantee that users don't think about that dialog as a "chooser". Furthermore, "Choose" doesn't indicate what is being chosen which, while I would like to think this is blazingly obvious, could probably stand to be indicated.

Compare this request for a choose right-click menu item. The default click action is left-click, left-click does what you want, we are discussing adding a right-click menu option (on which you will likely left-click) to duplicate the default left-click action.

No, there is absolutely no need for a button for this in the New/Modify? Account dialog. At best we should drop the Remove button and use a menu (which menu should get the new item we are discussing here).

comment:7 Changed 10 years ago by rlaager@…

  • Milestone changed from Patches Needing Review to 2.6.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 7c81031b004dcc2db48d2113ddeb7e00aeab977a):
A patch from nops to add a "Select Buddy Icon" (my term, the original patch used "Choose") option to the right-click menu of the buddy list's buddy icon selector. This is nice from an intuitiveness and HIG-compliance stance. Fixes #8775

comment:8 Changed 10 years ago by rlaager

The GNOME HIG says (or said, the last time I checked) that the first action in the right-click menu should be the left-click action. If nothing else, this provides the benefit of allowing users to see what a left click is going to do.

We intentionally violate this recommendation for buddies in the buddy list (where Get Info, not IM) is on top. I've always found that choice silly. Either we should follow the HIG or not show IM at all. But back on topic...

I like this. I'm committing it, with the text changed to "Select Buddy Icon" and GTK_STOCK_ADD as the icon. deryni, if you absolutely hate it, please let me know.

comment:9 Changed 10 years ago by deryni

I only hated 'Choose', the idea is fine and like I said I'm tempted to make this same change in the Modify Account dialog (though it would likely be less obvious there).

As to the Get Info thing it also irks me that we intentionally violate things there but despite that I think it is reasonable that we do, unless we want to go on a compain to champion double-middle-clicking instead. =)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!