Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8831 closed patch (fixed)

Patch for batching multi-second timeouts using purple_timeout_add_seconds in pidgin/finch

Reported by: arunanbala Owned by: sadrul
Milestone: 2.5.6 Component: finch (gnt/ncurses)
Version: 2.5.5 Keywords:
Cc:

Description (last modified by arunanbala)

This is a patch for Finch to batch some timeouts, described in https://wiki.ubuntu.com/SavingTheWorld and previous changes to eventloop.c in Pidgin (noted in chagelog for release 2.1.0).

Using purple_timeout_add_seconds allows for multiple timers to be fired at once, allowig CPUs to sleep longer and increasing power efficiency.

I did not change a few possible cases in finch/libgnt as it seems that libgnt is not meant to be libpurple dependent - is that the case? If so, would #ifdeffing for glib 2.14 be OK in those cases?

Attachments (1)

finch_timeouts.diff (3.0 KB) - added by arunanbala 10 years ago.
Patch for pidgin/finch, but not pidgn/finch/libgnt

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by arunanbala

Patch for pidgin/finch, but not pidgn/finch/libgnt

comment:1 Changed 10 years ago by arunanbala

  • Summary changed from Patch for batching multi-second timeouts using in pidgin/finch to Patch for batching multi-second timeouts using purple_timeout_add_seconds in pidgin/finch

comment:2 Changed 10 years ago by darkrain42

  • Milestone set to Patches Needing Review

comment:3 Changed 10 years ago by arunanbala

  • Description modified (diff)

comment:4 Changed 10 years ago by sadrul

Thanks for the patch. I went ahead and used this in finch/libgnt/ too, where possible. I mentioned you as 'Arunan Bala' in our COPYRIGHT file. Please let us know if you would prefer a different name to go in instead.

comment:5 Changed 10 years ago by sadrul@…

  • Milestone changed from Patches Needing Review to 2.6.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 143e16e91e423b92535ef8aac4bf1158f4a6186c):
Save the world.

Patch from Arunan Bala to save the world. But instead of saving the cheerleader, he's using g_timeout_add_seconds where possible in place of g_timeout_add. Closes #8831.

comment:6 Changed 10 years ago by arunanbala

I'd prefer "Arunan Balasubramaniam" if you don't mind, as a few different names start "Bala". I tried to set my full name as my display name in Trac, but did not find that option.

Thanks for doing the libgnt parts too!

comment:7 Changed 10 years ago by sadrul@…

(In 2a35218412842ba07897cde95941adafb3543dec):
* Plucked rev 143e16e9 (sadrul@…): Save the world.

Patch from Arunan Bala to save the world. But instead of saving the cheerleader, he's using g_timeout_add_seconds where possible in place of g_timeout_add. Closes #8831.

* Plucked rev 4a4ac072 (sadrul@…): Update the copyright name, as requested.

* Plucked rev 91e51efe (sadrul@…): Update the finch manual some. Refs #8577.

comment:8 Changed 10 years ago by darkrain42

  • Milestone changed from 2.6.0 to 2.5.6
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!